llvmPackages_12: 12.0.0-rc5 -> 12.0.0

[primeos]

Release notes: https://releases.llvm.org/12.0.0/docs/ReleaseNotes.html

Motivation for this change

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[primeos]

@GrahamcOfBorg build llvmPackages_12

[r-rmcgibbo]

Result of nixpkgs-review pr 119541 at 2c2e866 run on x86_64-linux 1

19 packages skipped due to time constraints:

• chromium
• clang_12 (llvmPackages_12.clang ,llvmPackages_12.libstdcxxClang)
• lld_12 (llvmPackages_12.lld)
• lldb_12 (llvmPackages_12.lldb)
• llvmPackages_12.bintools
• llvmPackages_12.clang-manpages
• llvmPackages_12.clang-unwrapped
• llvmPackages_12.compiler-rt
• llvmPackages_12.libclang
• llvmPackages_12.libcxxClang
• ...

3 packages built successfully:

• llvmPackages_12.libcxx
• llvmPackages_12.libcxxabi
• llvmPackages_12.libunwind

18 suggestions:

• warning: license-missing

  Package is missing a license.

  Near pkgs/development/compilers/llvm/12/libunwind/default.nix:20:3:

     |
  20 |   cmakeFlags = lib.optional (!enableShared) "-DLIBUNWIND_ENABLE_SHARED=OFF";
     |   ^
  

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/compilers/llvm/12/lldb/default.nix:75:3:

     |
  75 |   meta = with lib; {
     |   ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/development/compilers/llvm/12/clang/default.nix:98:5:

     |
  98 |     installPhase = ''
     |     ^
  

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/development/compilers/llvm/12/clang/default.nix:39:7:

     |
  39 |       ./purity.patch
     |       ^
  

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/compilers/llvm/12/compiler-rt/default.nix:19:3:

     |
  19 |   NIX_CFLAGS_COMPILE = [
     |   ^
  

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/compilers/llvm/12/libunwind/default.nix:20:3:

     |
  20 |   cmakeFlags = lib.optional (!enableShared) "-DLIBUNWIND_ENABLE_SHARED=OFF";
     |   ^
  

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/compilers/llvm/12/lld/default.nix:33:3:

     |
  33 |   meta = {
     |   ^
  

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/development/compilers/llvm/12/compiler-rt/default.nix:52:5:

     |
  52 |     ./compiler-rt-codesign.patch # Revert compiler-rt commit that makes codesign mandatory
     |     ^
  

• warning: unused-argument

  Unused argument: fetchpatch.
  Near pkgs/development/compilers/llvm/12/libc++/default.nix:1:23:

    |
  1 | { lib, stdenv, fetch, fetchpatch, cmake, python3, libcxxabi, llvm, fixDarwinDylibNames, version
    |                       ^
  

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/compilers/llvm/12/libc++/default.nix:43:3:

     |
  43 |   meta = {
     |   ^
  

• warning: missing-phase-hooks

  installPhase should probably contain runHook preInstall and runHook postInstall.

  Near pkgs/development/compilers/llvm/12/libc++abi/default.nix:37:3:

     |
  37 |   installPhase = if stdenv.isDarwin
     |   ^
  

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/compilers/llvm/12/clang/default.nix:85:5:

     |
  85 |     meta = {
     |     ^
  

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/development/compilers/llvm/12/lldb/default.nix:30:15:

     |
  30 |   patches = [ ./lldb-procfs.patch ];
     |               ^
  

• warning: license-missing

  Package is missing a license.

  Near pkgs/development/compilers/llvm/12/compiler-rt/default.nix:19:3:

     |
  19 |   NIX_CFLAGS_COMPILE = [
     |   ^
  

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/compilers/llvm/12/openmp.nix:19:3:

     |
  19 |   meta = {
     |   ^
  

• warning: missing-phase-hooks

  buildPhase should probably contain runHook preBuild and runHook postBuild.

  Near pkgs/development/compilers/llvm/12/clang/default.nix:94:5:

     |
  94 |     buildPhase = ''
     |     ^
  

• warning: license-missing

  Package is missing a license.

  Near pkgs/development/compilers/llvm/12/clang/default.nix:108:5:

      |
  108 |     meta.description = "man page for Clang ${version}";
      |     ^
  

• warning: maintainers-missing

  Package does not have a maintainer. Consider adding yourself?

  Near pkgs/development/compilers/llvm/12/clang/default.nix:108:5:

      |
  108 |     meta.description = "man page for Clang ${version}";
      |     ^
  

---

Result of nixpkgs-review pr 119541 at 2c2e866 run on aarch64-linux 1

16 packages skipped due to time constraints:

• chromium
• clang_12 (llvmPackages_12.clang ,llvmPackages_12.libstdcxxClang)
• lld_12 (llvmPackages_12.lld)
• lldb_12 (llvmPackages_12.lldb)
• llvmPackages_12.clang-unwrapped
• llvmPackages_12.libclang
• llvmPackages_12.libcxxClang
• llvmPackages_12.libcxxStdenv
• llvmPackages_12.lldClang
• llvmPackages_12.lldClangNoCompilerRt
• ...

2 packages built successfully:

• llvmPackages_12.libcxx
• llvmPackages_12.libcxxabi

1 suggestion:

• warning: missing-patch-comment

  Please add a comment on the line above, explaining the purpose of this patch.
  Near pkgs/development/compilers/llvm/12/clang/default.nix:39:7:

     |
  39 |       ./purity.patch
     |       ^
  

[vcunat]

It isn't new but occasionally we get error in one test: https://hydra.nixos.org/build/141548680

Failed Tests (1):
  LLVM :: tools/llvm-exegesis/X86/uops-CMOV16rm-noreg.s

Not sure what to do about the cases; so far they just got restarted until succeeding.

[primeos]

I've just noticed this too because the Chromium build failed. Is it always the same test (and does it happen frequently)? If so it would seem like a good idea to try to disable it.

[vcunat]

Always the same test, in the cases I've seen. Last time in LLVM 11, I think. I saw some revert upstream but that seemed already included in the relevant releases.

[vcunat]

Here's one with LLVM 9. Maybe some change in (some of) the build machines triggered these appearances.

[lukegb]

I filed #119673 for this. Basically, if it builds on wendy, it'll break :(

[vcunat]

@primeos: was it intentional not to bump llvmPackages_latest?

[primeos]

@primeos: was it intentional not to bump llvmPackages_latest?

Yes, in the past we often waited a few weeks in case some issues/regressions appear and in case we want to make a few additional changes before it affects a lot of rebuilds. I've currently repurposed #116646 for llvmPackages_latest (that PR can be replaced in case someone else has time). I didn't perform that change in the past so I'm also not sure how best to test it (I guess a Hydra jobset would make sense?).