fix(public): point brief-requested nav and back links at clean non-307 paths - #97
fix(public): point brief-requested nav and back links at clean non-307 paths#97nish3451 wants to merge 13 commits into
Conversation
The post-signup /brief-requested page still linked its logo, nav and back link at the .html forms (index.html, audit.html, agents.html, pricing.html), each of which the worker 307-redirects to its clean extensionless twin — the same redirecting-internal-link fault PR #34 removed from the five public pages, left unfixed on the sixth surface. Point the five anchors at /, /audit, /agents, /pricing and extend the check-site.mjs internal-links guard (dogfood 996dffe45ef7) to cover the brief-requested page so the shape cannot return.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reached
Next review available in: 28 seconds Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe confirmation page now uses root-relative navigation routes. The site checker also scans ChangesNavigation route cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90645c2620
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ["pricing page", read("public/pricing.html")], | ||
| ["specimen page", read("public/specimen.html")] | ||
| ["specimen page", read("public/specimen.html")], | ||
| ["brief-requested page", read("public/brief-requested.html")] |
There was a problem hiding this comment.
When a brief-requested link is written in the common root-relative form href="/audit.html", target remains /audit.html, which is not a key in htmlPageTargets; the checker therefore passes even though the link still hits the redirecting .html endpoint. I confirmed this by substituting /audit.html on the newly guarded page and running node scripts/check-site.mjs, which exited successfully, so the detector added here does not reliably prevent the regression it is intended to cover.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d07d750566
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ["pricing page", read("public/pricing.html")], | ||
| ["specimen page", read("public/specimen.html")] | ||
| ["specimen page", read("public/specimen.html")], | ||
| ["brief-requested page", read("public/brief-requested.html")] |
There was a problem hiding this comment.
When any guarded page contains href="brief-requested.html", adding this page to internalLinkPages still does not report the redirecting link because htmlPageTargets has no brief-requested.html entry. I verified this by replacing one of this page's clean links with that value and running node scripts/check-site.mjs, which still passed; add the confirmation route mapping so the guard covers the .html twin of every included public page.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Stale duplicate of PR #145 (head branch |
1 participant
What
The post-signup surface at
/brief-requested(public/brief-requested.html) still carried the redirecting-internal-link fault PR #34 removed from the five public pages: its logo, three nav links and the back link pointed at.htmlforms that the deployed worker 307-redirects to their clean extensionless twins:index.html→ 307 →//audit.html→ 307 →/audit/auditagents.html→ 307 →/agents/agentspricing.html→ 307 →/pricing/pricingindex.html→ 307 →//Why it slipped past the guard
The "Internal page links (dogfood 996dffe45ef7)" guard in
scripts/check-site.mjsonly covered the five public pages —brief-requested.htmlwas not ininternalLinkPages. This PR fixes the instance and the detector: the guard now includes the brief-requested page, and a negative probe confirmed it fails if any.htmlpage-name anchor returns there.Validation
npm run checkpasses with the fix; fails on a deliberately re-introducedhref="audit.html"(then passes again after restore).npm run testsuites green: headings 6/6, sitemap 7/7, worker 53/53, UI 16/16, contract 8/8 (90 tests total).Files
public/brief-requested.html— five anchors pointed at clean pathsscripts/check-site.mjs— internal-links guard extended to cover the post-signup pageSummary by CodeRabbit
Bug Fixes
.htmlURLs.Tests
.htmladdresses.