Skip to content

fix(public): point brief-requested nav and back links at clean non-307 paths #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nish3451 wants to merge 13 commits into from
Closed

fix(public): point brief-requested nav and back links at clean non-307 paths #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ad5164e
fix(public): point brief-requested links at clean non-307 paths
nish3451 Aug 11, 2026
90645c2
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
d07d750
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
a237f49
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
167b9fd
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
56884fa
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
fa2ee08
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
7b8bf18
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
307fa21
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
3f074ec
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
35d064c
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
4b0f3ec
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
71a2aa8
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions public/brief-requested.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
<body>
<div class="wrap">
<nav>
<a class="logo" href="index.html">Tiny<span>Studio</span></a>
<a class="logo" href="/">Tiny<span>Studio</span></a>
<div class="navlinks">
<a href="audit.html">The appraisal</a>
<a href="agents.html">The desk</a>
<a href="pricing.html">Pricing</a>
<a href="/audit">The appraisal</a>
<a href="/agents">The desk</a>
<a href="/pricing">Pricing</a>
</div>
</nav>

Expand All @@ -51,7 +51,7 @@ <h1>That's it. <em>Nothing else needed from you.</em></h1>
</div>
</div>

<a class="back" href="index.html">Back to the site</a>
<a class="back" href="/">Back to the site</a>
</div>

<footer>
Expand Down
15 changes: 9 additions & 6 deletions scripts/check-site.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,17 +1457,20 @@ for (const [pageName, pageHtml, pageUrl] of structuredDataPages) {
// point at the final destination URL: the dogfood run reported every .html
// navigation target on home ("index.html" -> "/", "audit.html" -> "/audit",
// "agents.html" -> "/agents", "pricing.html" -> "/pricing", "specimen.html" ->
// "/specimen") as a redirecting internal link. The five public pages must
// therefore point every page link at the clean URL the worker serves, never
// at a .html file that resolves to it. These are STATIC SOURCE GUARDS (regex
// over the served files): CI has no browser, so they assert the .html target
// shape cannot return, not that the redirects are absent on the network.
// "/specimen") as a redirecting internal link. The five public pages (and the
// /brief-requested post-signup page, which carries the same logo/nav/back
// shell) must therefore point every page link at the clean URL the worker
// serves, never at a .html file that resolves to it. These are STATIC SOURCE
// GUARDS (regex over the served files): CI has no browser, so they assert the
// .html target shape cannot return, not that the redirects are absent on the
// network.
const internalLinkPages = [
["homepage", siteHome],
["audit page", siteAudit],
["desk page", read("public/agents.html")],
["pricing page", read("public/pricing.html")],
["specimen page", read("public/specimen.html")]
["specimen page", read("public/specimen.html")],
["brief-requested page", read("public/brief-requested.html")]

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize root-relative HTML targets in the added guard

When a brief-requested link is written in the common root-relative form href="/audit.html", target remains /audit.html, which is not a key in htmlPageTargets; the checker therefore passes even though the link still hits the redirecting .html endpoint. I confirmed this by substituting /audit.html on the newly guarded page and running node scripts/check-site.mjs, which exited successfully, so the detector added here does not reliably prevent the regression it is intended to cover.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the confirmation route in redirect targets

When any guarded page contains href="brief-requested.html", adding this page to internalLinkPages still does not report the redirecting link because htmlPageTargets has no brief-requested.html entry. I verified this by replacing one of this page's clean links with that value and running node scripts/check-site.mjs, which still passed; add the confirmation route mapping so the guard covers the .html twin of every included public page.

Useful? React with 👍 / 👎.

];

const htmlPageTargets = {
Expand Down
Loading