Conversation
…7 paths The post-signup page still carried the redirecting internal links the leak audit flags: its logo, nav and back anchors targeted .html files that 307-redirect to the clean extensionless twins the worker serves (index.html -> /, audit.html -> /audit, agents.html -> /agents, pricing.html -> /pricing). PR #34 fixed the five indexable pages and guarded them in check-site.mjs, but brief-requested.html was missed. Point every anchor on brief-requested.html at the clean URL and extend the internal page links guard to cover the sixth served page, so the redirecting shape cannot return on the post-signup surface.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reached
Next review available in: 4 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe confirmation page now uses root-relative clean URLs for navigation. The site checker validates the ChangesClean URL navigation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0cf0027f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "pricing.html": "/pricing", | ||
| "specimen.html": "/specimen" | ||
| "specimen.html": "/specimen", | ||
| "brief-requested.html": "/brief-requested" |
There was a problem hiding this comment.
The page now uses root-relative links such as /audit, but every lookup key here omits the leading slash. Consequently, changing one of the newly covered links to /audit.html leaves target as /audit.html, which does not match audit.html, and the check still passes. I verified this by making that substitution on this commit and running scripts/check-site.mjs; it reported success. Normalize the target or include root-relative keys so the guard actually prevents the redirect regression it claims to cover.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Closing as the stale duplicate in the duplicate open-PR reconciliation (docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11): #97 re-lands the byte-identical brief-requested clean-links fix (public/brief-requested.html anchors + the check-site.mjs internal-links guard extension) on the fresh current-main base, while this branch is mergeStateStatus BEHIND against a stale base and its body lacks the guard-coverage receipt. Verified: the brief-requested.html diff and the guard extension are identical between #60 and #97 (only guard-comment wording differs); #97 passes npm run check on its own tree and sits directly on current origin/main HEAD (a30f2ad). #97 is the superior delivery path. |
1 participant
What
The post-signup surface (
/brief-requested) still carried the redirecting internal links this site's own leak audit flags. Its logo, nav ("The appraisal", "The desk", "Pricing") and "Back to the site" anchors targeted.htmlfiles that 307-redirect to the clean extensionless twins the worker serves:index.html→ 307 →/audit.html→ 307 →/auditagents.html→ 307 →/agentspricing.html→ 307 →/pricingPR #34 (dogfood finding 996dffe45ef7) fixed the five indexable pages and added the
check-site.mjsinternal page links guard, butbrief-requested.htmlwas left out — so every link a real user clicks after signup still resolves through a 307.Change
public/brief-requested.html— every anchor now points at the clean URL (/,/audit,/agents,/pricing), never a.htmlform that resolves to it.scripts/check-site.mjs— the internal page links guard now covers the sixth served page (brief-requested pageininternalLinkPages,brief-requested.html → /brief-requestedinhtmlPageTargets), so the redirecting shape cannot return.Validation
npm run check— passed (incl. the extended internal links guard)npm test— passed: 6/6 headings, 7/7 sitemap, 53/53 worker, 16/16 UI/audit→audit.htmlmakesnpm run checkfail withInternal page link on brief-requested page must point at the clean destination "/audit" (found "audit.html")., proving the guard bites.Evidence
docs/evidence/internal-links-2026-08-09.md— live 307 baseline for the five.htmlformsdocs/evidence/sitemap-2026-08-09.md—/brief-requestedserved as the noindex signup pageSummary by CodeRabbit
Bug Fixes
Tests