This repository was archived by the owner on Sep 28, 2026. It is now read-only.
Repository navigation
fix(public): point brief-requested nav and back links at clean non-307 paths #97
Closed
Closed
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ad5164e
fix(public): point brief-requested links at clean non-307 paths
nish3451 90645c2
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 d07d750
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 a237f49
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 167b9fd
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 56884fa
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 fa2ee08
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 7b8bf18
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 307fa21
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 3f074ec
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 35d064c
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 4b0f3ec
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 71a2aa8
Merge branch 'main' into fix/brief-requested-clean-links
nish3451 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1457,17 +1457,20 @@ for (const [pageName, pageHtml, pageUrl] of structuredDataPages) { | |
| // point at the final destination URL: the dogfood run reported every .html | ||
| // navigation target on home ("index.html" -> "/", "audit.html" -> "/audit", | ||
| // "agents.html" -> "/agents", "pricing.html" -> "/pricing", "specimen.html" -> | ||
| // "/specimen") as a redirecting internal link. The five public pages must | ||
| // therefore point every page link at the clean URL the worker serves, never | ||
| // at a .html file that resolves to it. These are STATIC SOURCE GUARDS (regex | ||
| // over the served files): CI has no browser, so they assert the .html target | ||
| // shape cannot return, not that the redirects are absent on the network. | ||
| // "/specimen") as a redirecting internal link. The five public pages (and the | ||
| // /brief-requested post-signup page, which carries the same logo/nav/back | ||
| // shell) must therefore point every page link at the clean URL the worker | ||
| // serves, never at a .html file that resolves to it. These are STATIC SOURCE | ||
| // GUARDS (regex over the served files): CI has no browser, so they assert the | ||
| // .html target shape cannot return, not that the redirects are absent on the | ||
| // network. | ||
| const internalLinkPages = [ | ||
| ["homepage", siteHome], | ||
| ["audit page", siteAudit], | ||
| ["desk page", read("public/agents.html")], | ||
| ["pricing page", read("public/pricing.html")], | ||
| ["specimen page", read("public/specimen.html")] | ||
| ["specimen page", read("public/specimen.html")], | ||
| ["brief-requested page", read("public/brief-requested.html")] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When any guarded page contains Useful? React with 👍 / 👎. |
||
| ]; | ||
|
|
||
| const htmlPageTargets = { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a brief-requested link is written in the common root-relative form
href="/audit.html",targetremains/audit.html, which is not a key inhtmlPageTargets; the checker therefore passes even though the link still hits the redirecting.htmlendpoint. I confirmed this by substituting/audit.htmlon the newly guarded page and runningnode scripts/check-site.mjs, which exited successfully, so the detector added here does not reliably prevent the regression it is intended to cover.Useful? React with 👍 / 👎.