docs(evidence): reconcile the two residual duplicate open-PR clusters to one superior delivery path per surface - #109
Conversation
… to one superior delivery path per surface
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdded evidence for two residual duplicate open-PR clusters. The document records branch verification, stale PR closure, surviving PR checks, and completion of duplicate fix-PR reconciliation. ChangesDuplicate PR reconciliation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc848c6f70
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Per-cluster diffs confirmed the stale branches carried no unique fix | ||
| content the survivor lacks: #60 vs #97 differ only in guard-comment wording | ||
| (fix commits `db7b2b1` vs `ad5164e`); #47 vs #85 differ only in the extra | ||
| `brief-requested.html` link and check-site.mjs guard the original carried | ||
| (the five-page instance fix is byte-identical). |
There was a problem hiding this comment.
Preserve #47’s unique favicon coverage before closing it
When #47 remains closed and #85 becomes the sole delivery path, the brief-requested.html favicon and the automated favicon guard have no surviving branch: this receipt itself identifies both as changes present only in #47, while the current plan lists /brief-requested as a public surface (specs/004-website-appraisal/plan.md:17-24). Therefore the claim that the stale branch carried “no unique fix content” is false, and merging #85 would silently discard both coverage and regression detection. Re-land those changes in #85, or explicitly document and justify rejecting them rather than treating #47 as a complete duplicate.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md (1)
89-92: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winPin the verification to immutable commit IDs.
The receipt records the mutable survivor branch names and the
origin/mainSHA, but it does not record the exact head SHA for PR#85or PR#97or thenpm run checkoutput. Add the survivor head SHAs and the check result or artifact so the closure decision remains reproducible.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md` around lines 89 - 92, Update the verification receipt describing PR `#85` and PR `#97` to record each survivor’s immutable head commit SHA instead of only branch names, and include the corresponding npm run check result or artifact. Preserve the existing origin/main SHA and per-survivor verification context so the closure decision is reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md`:
- Line 59: Wrap the PR references beginning paragraphs, including `#47` and `#85`
and the reference at the additionally noted location, in Markdown inline code
formatting so markdownlint no longer interprets them as headings. Preserve the
surrounding text and links unchanged.
---
Nitpick comments:
In `@docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md`:
- Around line 89-92: Update the verification receipt describing PR `#85` and PR
`#97` to record each survivor’s immutable head commit SHA instead of only branch
names, and include the corresponding npm run check result or artifact. Preserve
the existing origin/main SHA and per-survivor verification context so the
closure decision is reproducible.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 0f0566d6-4a28-4219-a810-89a399630e52
📒 Files selected for processing (1)
docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md
| type="image/svg+xml" />` line to the five human-facing pages | ||
| (`public/index.html`, `pricing.html`, `audit.html`, `agents.html`, | ||
| `specimen.html`) — verified byte-identical line-for-line on all five pages. | ||
| #47 is the original branch, conflict-locked against current main |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Escape PR references that start with #.
Markdownlint reports MD018 for #47 and #85 at the start of paragraphs. Wrap each reference in code formatting.
Proposed fix
-#47 is the original branch, conflict-locked against current main
+`#47` is the original branch, conflict-locked against current main
-#85's body names `fix/serve-rel-icon-favicon` as "a stale duplicate branch ... never
+`#85`'s body names `fix/serve-rel-icon-favicon` as "a stale duplicate branch ... neverAlso applies to: 66-66
🧰 Tools
🪛 markdownlint-cli2 (0.23.2)
[warning] 59-59: No space after hash on atx style heading
(MD018, no-missing-space-atx)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md` at line 59,
Wrap the PR references beginning paragraphs, including `#47` and `#85` and the
reference at the additionally noted location, in Markdown inline code formatting
so markdownlint no longer interprets them as headings. Preserve the surrounding
text and links unchanged.
Source: Linters/SAST tools
What
Reconciles the two residual duplicate open fix-PR clusters left after PR #105 so the drain cannot merge both members of a pair. Closes the two stale duplicates, each with a comment naming the surviving delivery path:
Why
Two open PRs per surface is a defect: reviewers cannot tell which is canonical, the stale branch tends to conflict-lock against main, and a merge of the wrong one re-introduces drift. #105 closed four such clusters; these were the two remaining, each an original branch against a stale base plus the fresh re-land.
Verification
npm run checkgreen on each survivor, fetched fresh and run on its own tree; each sits directly on currentorigin/mainHEAD (a30f2ad).docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md).Closes
The duplicate-open-fix-PR reconciliation item's residual pair: combined with #105's four clusters, every duplicate open fix-PR pair in the repository now has exactly one delivery path.
Summary by CodeRabbit