Skip to content

docs(evidence): reconcile the two residual duplicate open-PR clusters to one superior delivery path per surface - #109

Merged
nish3451 merged 2 commits into
mainfrom
docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11
Aug 11, 2026
Merged

docs(evidence): reconcile the two residual duplicate open-PR clusters to one superior delivery path per surface#109
nish3451 merged 2 commits into
mainfrom
docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11

Conversation

@nish3451

@nish3451 nish3451 commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

What

Reconciles the two residual duplicate open fix-PR clusters left after PR #105 so the drain cannot merge both members of a pair. Closes the two stale duplicates, each with a comment naming the surviving delivery path:

cluster closed (stale) survivor
brief-requested clean nav/back links #60 (stale base, BEHIND) #97
rel=icon favicon on the five public pages #47 (conflict-locked, DIRTY) #85

Why

Two open PRs per surface is a defect: reviewers cannot tell which is canonical, the stale branch tends to conflict-lock against main, and a merge of the wrong one re-introduces drift. #105 closed four such clusters; these were the two remaining, each an original branch against a stale base plus the fresh re-land.

Verification

Closes

The duplicate-open-fix-PR reconciliation item's residual pair: combined with #105's four clusters, every duplicate open fix-PR pair in the repository now has exactly one delivery path.

Summary by CodeRabbit

  • Documentation
    • Added evidence documenting the reconciliation of two residual duplicate pull-request clusters.
    • Recorded verification that stale pull requests contained no unique fix content before closure.
    • Documented successful checks on the surviving delivery branches and confirmation that all duplicate fix pairs were reconciled.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c569210-8359-4246-a9fb-da0077bdfb12

📥 Commits

Reviewing files that changed from the base of the PR and between dc848c6 and 9dee97b.

📒 Files selected for processing (1)
  • docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md

📝 Walkthrough

Walkthrough

Added evidence for two residual duplicate open-PR clusters. The document records branch verification, stale PR closure, surviving PR checks, and completion of duplicate fix-PR reconciliation.

Changes

Duplicate PR reconciliation

Layer / File(s) Summary
Residual cluster verification
docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md
Documents the two residual clusters, branch comparisons, verification checks, and selection of PRs #97 and #85.
Stale PR closure and final reconciliation
docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md
Records closure of PRs #60 and #47 and confirms one checked delivery path per surface.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the documented reconciliation of two residual duplicate open-PR clusters.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11

Comment @coderabbitai help to get the list of available commands.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc848c6f70

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +84 to +88
- Per-cluster diffs confirmed the stale branches carried no unique fix
content the survivor lacks: #60 vs #97 differ only in guard-comment wording
(fix commits `db7b2b1` vs `ad5164e`); #47 vs #85 differ only in the extra
`brief-requested.html` link and check-site.mjs guard the original carried
(the five-page instance fix is byte-identical).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve #47’s unique favicon coverage before closing it

When #47 remains closed and #85 becomes the sole delivery path, the brief-requested.html favicon and the automated favicon guard have no surviving branch: this receipt itself identifies both as changes present only in #47, while the current plan lists /brief-requested as a public surface (specs/004-website-appraisal/plan.md:17-24). Therefore the claim that the stale branch carried “no unique fix content” is false, and merging #85 would silently discard both coverage and regression detection. Re-land those changes in #85, or explicitly document and justify rejecting them rather than treating #47 as a complete duplicate.

Useful? React with 👍 / 👎.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md (1)

89-92: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Pin the verification to immutable commit IDs.

The receipt records the mutable survivor branch names and the origin/main SHA, but it does not record the exact head SHA for PR #85 or PR #97 or the npm run check output. Add the survivor head SHAs and the check result or artifact so the closure decision remains reproducible.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md` around lines
89 - 92, Update the verification receipt describing PR `#85` and PR `#97` to record
each survivor’s immutable head commit SHA instead of only branch names, and
include the corresponding npm run check result or artifact. Preserve the
existing origin/main SHA and per-survivor verification context so the closure
decision is reproducible.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md`:
- Line 59: Wrap the PR references beginning paragraphs, including `#47` and `#85`
and the reference at the additionally noted location, in Markdown inline code
formatting so markdownlint no longer interprets them as headings. Preserve the
surrounding text and links unchanged.

---

Nitpick comments:
In `@docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md`:
- Around line 89-92: Update the verification receipt describing PR `#85` and PR
`#97` to record each survivor’s immutable head commit SHA instead of only branch
names, and include the corresponding npm run check result or artifact. Preserve
the existing origin/main SHA and per-survivor verification context so the
closure decision is reproducible.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0f0566d6-4a28-4219-a810-89a399630e52

📥 Commits

Reviewing files that changed from the base of the PR and between a30f2ad and dc848c6.

📒 Files selected for processing (1)
  • docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md

type="image/svg+xml" />` line to the five human-facing pages
(`public/index.html`, `pricing.html`, `audit.html`, `agents.html`,
`specimen.html`) — verified byte-identical line-for-line on all five pages.
#47 is the original branch, conflict-locked against current main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Escape PR references that start with #.

Markdownlint reports MD018 for #47 and #85 at the start of paragraphs. Wrap each reference in code formatting.

Proposed fix
-#47 is the original branch, conflict-locked against current main
+`#47` is the original branch, conflict-locked against current main

-#85's body names `fix/serve-rel-icon-favicon` as "a stale duplicate branch ... never
+`#85`'s body names `fix/serve-rel-icon-favicon` as "a stale duplicate branch ... never

Also applies to: 66-66

🧰 Tools
🪛 markdownlint-cli2 (0.23.2)

[warning] 59-59: No space after hash on atx style heading

(MD018, no-missing-space-atx)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/evidence/duplicate-open-pr-clusters-residual-2026-08-11.md` at line 59,
Wrap the PR references beginning paragraphs, including `#47` and `#85` and the
reference at the additionally noted location, in Markdown inline code formatting
so markdownlint no longer interprets them as headings. Preserve the surrounding
text and links unchanged.

Source: Linters/SAST tools

@nish3451
nish3451 merged commit 9eb607d into main Aug 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant