docs(evidence): re-verify the two post-#105 duplicate open-PR clusters against current GitHub state (2026-08-12) - #163
Conversation
…s against current GitHub state (2026-08-12)
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reached
Next review available in: 3 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f90ccbb7ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| comment wording; #60 additionally carried a `"brief-requested.html" → | ||
| "/brief-requested"` `htmlPageTargets` entry that the re-lands scoped out — | ||
| no fault coverage is lost, because every real `.html` target on the page | ||
| (`index.html`, `audit.html`, `agents.html`, `pricing.html`) remains a | ||
| guarded `htmlPageTargets` key. |
There was a problem hiding this comment.
When any guarded page links to brief-requested.html, the survivor's check will silently pass: scripts/check-site.mjs only rejects hrefs present in htmlPageTargets, while src/worker.js serves both /brief-requested.html and its clean /brief-requested twin. Therefore #60's extra mapping does provide unique regression coverage, contrary to the claim that no coverage is lost; either preserve that mapping in #145 or stop treating #60 as carrying no guard behavior the survivor lacks.
Useful? React with 👍 / 👎.
…idual-reverify-2026-08-12
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc7e361777
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| delivery path** for the brief-requested clean-links fix. Its head (`47d42e7`) | ||
| contains current `origin/main` (`cab6d18`), it is `mergeable: MERGEABLE`, and |
There was a problem hiding this comment.
At the reviewed commit, origin/main is already b42ed76, a descendant of the cited cab6d18; moreover, the receipt says #145's last commit was pushed at 13:00Z, before b42ed76 was committed at 13:53Z. Thus #145 cannot be sitting on the current main as claimed, undermining the fresh-base justification for selecting it as the superior delivery path. Refresh/re-verify #145 against b42ed76 or state the verification's exact earlier cutoff.
Useful? React with 👍 / 👎.
1 participant
What
Reconcile/re-verify the two residual duplicate open fix-PR clusters left after PR #105 (
docs/evidence/duplicate-open-pr-clusters-2026-08-11.md), per the 2026-08-11 residual receipt and the repo's one-delivery-path-per-surface pattern.Findings (GitHub state, 2026-08-12)
fix/brief-requested-clean-links-lane1) is the sole open delivery path: its head contains currentorigin/main, it is MERGEABLE (awaiting review), and its tree is verified green (npm run check+npm test, 92 subtests, plus a negative probe proving the extended guard fails on a re-introduced.htmlanchor). Fix-content identity verified: fix(public): point brief-requested nav and back links at clean non-307 paths #60's page change is byte-identical to fix(public): point brief-requested nav and back links at clean non-307 paths #145's; fix(public): point brief-requested nav and back links at clean non-307 paths #97's fix commit (ad5164e) is identical to fix(public): point brief-requested nav and back links at clean non-307 paths #145's. The fix itself is still not on main — fix(public): point brief-requested nav and back links at clean non-307 paths #145 must be merged to deliver it.9302611), follow-up fix(public): serve rel=icon on /brief-requested and guard favicon links in check-site.mjs #113 merged (18128e8); the favicon guard on main now covers all seven served pages. No open carrier remains, which is the correct terminal state.Validation
npm run checkandnpm testgreen on thefix/brief-requested-clean-links-lane1tree (92 subtests: 6 headings, 7 sitemap, 55 worker, 16 UI, 8 contract).href="audit.html"re-introduced onpublic/brief-requested.htmlfails the check; restore passes.Files
docs/evidence/duplicate-open-pr-clusters-residual-reverify-2026-08-12.md— reconciliation receipt.