Updating Clang Version to 11.0.0 by codereport · Pull Request #6695 · NVIDIA/cudf

codereport · 2020-11-06T15:40:39Z

This resolves: #5187

PR description copied from: NVIDIA/cuml#3121

This PR will upgrade the clang version required to 11.0.0 in order to enable us with running clang-tidy on .cu files, while running on cuda v11. See NVIDIA/raft#88 for more details.

CI will not pass as the underlying conda-env still uses 8.0.1. Once we have the rapids-build-env meta package updated, this should pass.

Fixes from Clang 8.0.1 to Clang 11.0.0 (that are observed in delta)

Missing spaces
Incorrect alignment when ternary expression splits across multiple lines
Comment alignment on macros
Fixed where function signatures have line breaks
Aligning macros
Always left align pointer/reference
Don't allow single line for loops

To do list:

Update python file
Update conda environment files
Run formatter to apply all changes from upgrading
Add changes from [FEA] Upgrade clang-format to Clang 11 and other adjustments #5187
Review list of new changes from 8.0.1 to 11; choose which to incorporate
Get working with RAPID compose

GPUtester · 2020-11-06T15:41:13Z

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

codecov · 2020-11-06T18:26:34Z

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@d77ba82). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head ef10e1e differs from pull request most recent head 6632d7f. Consider uploading reports for the commit 6632d7f to get more accurate results

@@               Coverage Diff               @@
##             branch-21.08    #6695   +/-   ##
===============================================
  Coverage                ?   10.64%           
===============================================
  Files                   ?      109           
  Lines                   ?    18654           
  Branches                ?        0           
===============================================
  Hits                    ?     1985           
  Misses                  ?    16669           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d77ba82...6632d7f. Read the comment docs.

harrism · 2020-11-23T03:41:04Z

@codereport should we push this to 0.18?

codereport · 2020-11-23T16:07:57Z

@codereport should we push this to 0.18?

Yep, let's do that.

harrism · 2021-02-03T04:20:31Z

@codereport maybe we can get to this in 0.19.

codereport · 2021-02-03T04:52:50Z

@codereport maybe we can get to this in 0.19.

Yea sorry, this has been on the back burner. Will be one of my focuses in .19

ttnghia · 2021-05-21T18:59:28Z

Hi there. I'm curious about the state of this PR. How about it now?

harrism · 2021-05-24T20:32:37Z

Moving to 21.08

codereport · 2021-05-25T13:53:52Z

Hi there. I'm curious about the state of this PR. How about it now?

Hey @ttnghia, this has been on the back burner for a while. Once I finish with the AST PR Vyas and I are working on, this will be next on my list of things to do.

This reverts commit dd82582.

This reverts commit 01ff0a2.

dillon-cullinan

These lines should be removed. Update the clang version in the integration repo.

cwharris · 2021-07-04T21:40:29Z

@codereport we're missing a really great opportunity to title this PR

“Turn Clang up to 11”

codereport · 2021-07-06T14:25:53Z

rerun tests

codereport · 2021-07-06T17:27:12Z

rerun tests

Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/rmm` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Rong Ou (https://github.com/rongou) - Christopher Harris (https://github.com/cwharris) - Dillon Cullinan (https://github.com/dillon-cullinan) URL: #814

Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/cuspatial` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Dillon Cullinan (https://github.com/dillon-cullinan) - H. Thomson Comer (https://github.com/thomcom) URL: #426

codereport · 2021-07-07T01:42:28Z

@gpucibot merge

Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/cugraph` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Dillon Cullinan (https://github.com/dillon-cullinan) - Chuck Hastings (https://github.com/ChuckHastings) URL: #1688

Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/cuml` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - William Hicks (https://github.com/wphicks) - AJ Schmidt (https://github.com/ajschmidt8) - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) URL: #4029

Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/cuml` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - William Hicks (https://github.com/wphicks) - AJ Schmidt (https://github.com/ajschmidt8) - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) URL: NVIDIA#4029

codereport added 3 commits November 6, 2020 10:30

Updateing conda environment files

24fe605

Update python script

2e140c0

FORMATTING CHANGES FROM UPGRADING

01ff0a2

codereport added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. labels Nov 6, 2020

codereport requested review from harrism and jrhemstad November 6, 2020 15:40

codereport requested review from a team as code owners November 6, 2020 15:40

codereport self-assigned this Nov 6, 2020

Update CHANGELOG

dd82582

harrism reviewed Nov 8, 2020

View reviewed changes

Comment thread cpp/include/cudf/detail/utilities/device_atomics.cuh Outdated

teju85 mentioned this pull request Nov 9, 2020

[REVIEW] updated clang version to 11.0.0 rapidsai/integration#170

Closed

ajschmidt8 approved these changes Nov 9, 2020

View reviewed changes

codereport changed the title ~~[WIP] Updating Clang Version to 11.0.0~~ Updating Clang Version to 11.0.0 Dec 11, 2020

codereport marked this pull request as draft December 11, 2020 00:24

harrism changed the base branch from branch-0.17 to branch-0.19 February 3, 2021 04:20

codereport added 2 commits May 27, 2021 18:02

Revert "Update CHANGELOG"

6cee8ca

This reverts commit dd82582.

Revert "FORMATTING CHANGES FROM UPGRADING"

7c5a040

This reverts commit 01ff0a2.

github-actions Bot added the conda label May 27, 2021

codereport added the improvement Improvement / enhancement to an existing function label May 27, 2021

This was referenced Jun 25, 2021

Updating Clang Version to 11.0.0 rapidsai/rmm#814

Merged

Updating Clang Version to 11.0.0 rapidsai/cugraph#1688

Merged

dillon-cullinan suggested changes Jun 25, 2021

View reviewed changes

Comment thread ci/checks/style.sh Outdated

codereport mentioned this pull request Jun 26, 2021

Updating Clang Version to 11.0.0 rapidsai/cuspatial#426

Merged

codereport added 2 commits June 27, 2021 21:51

Remove duplicate line

31df552

Remove temporary CI fix

2d90823

github-actions Bot removed the gpuCI label Jun 28, 2021

codereport requested a review from dillon-cullinan June 28, 2021 01:53

Merge branch 'branch-21.08' into clang-11

27daf20

codereport mentioned this pull request Jun 28, 2021

Update to Clang Version to 11.0.0 rapidsai/integration#304

Merged

dillon-cullinan approved these changes Jun 28, 2021

View reviewed changes

codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jun 28, 2021

codereport added 2 commits June 28, 2021 10:17

Merge branch 'branch-21.08' into clang-11

0a1b719

Merge branch 'branch-21.08' into clang-11

876af0e

codereport mentioned this pull request Jul 5, 2021

Updating Clang Version to 11.0.0 NVIDIA/cuml#4029

Merged

codereport added 2 commits July 6, 2021 14:34

Merge branch 'branch-21.08' into clang-11

791f45a

Missing formatting

a487f7a

Merge branch 'branch-21.08' into clang-11

6632d7f

rapids-bot Bot merged commit 7721819 into NVIDIA:branch-21.08 Jul 7, 2021

vyasr mentioned this pull request Aug 5, 2021

Add clang-tidy for automatic linting #584

Closed

Uh oh!

Conversation

codereport commented Nov 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes from Clang 8.0.1 to Clang 11.0.0 (that are observed in delta)

Uh oh!

GPUtester commented Nov 6, 2020

Uh oh!

codecov Bot commented Nov 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

harrism commented Nov 23, 2020

Uh oh!

codereport commented Nov 23, 2020

Uh oh!

harrism commented Feb 3, 2021

Uh oh!

codereport commented Feb 3, 2021

Uh oh!

ttnghia commented May 21, 2021

Uh oh!

harrism commented May 24, 2021

Uh oh!

codereport commented May 25, 2021

Uh oh!

dillon-cullinan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cwharris commented Jul 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codereport commented Jul 6, 2021

Uh oh!

codereport commented Jul 6, 2021

Uh oh!

codereport commented Jul 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

codereport commented Nov 6, 2020 •

edited

Loading

codecov Bot commented Nov 6, 2020 •

edited

Loading

cwharris commented Jul 4, 2021 •

edited

Loading