[REVIEW] updated clang version to 11.0.0 - #170
Closed
teju85 wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
@codereport, can you check if the above claims are true for cudf too? (meaning, clang update doesn't cause much of clang-format violations) |
Contributor
Author
|
@codereport also tried upgrading to clang-11 in his PR here: NVIDIA/cudf#6695 and saw not much changes in cuDF too. So, it seems like it is safer to upgrade clang version on our meta recipe. |
ajschmidt8
approved these changes
Nov 9, 2020
Contributor
Author
|
Tagging relevant folks to let us know if they are ok with this version upgrade:
|
mike-wendt
added
4 - Needs Reviewer
Contributor
|
From @kkraus14 punt to 0.18 |
Contributor
|
@teju85 Is this still needed? |
Contributor
Author
|
@raydouglass Yes. This is still needed. However, we require a "go ahead" signal from the above code owners to proceed. |
Member
|
superseded by #390. closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why update?
If we want to enable running clang-tidy on .cu files, v8.0.1 does not even support CTK version 10, as described here: NVIDIA/raft#85. Thus, we need to update clang version.
Any risks due to this update?
None so far. I have tested this by running clang-tidy and clang-format on both cuML and raft repo's:
Specifically, the set of changes caused by clang-format is almost negligible.