This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Updating Clang Version to 11.0.0 - #426
Merged
Merged
Conversation
github-actions
Bot
added
conda
dillon-cullinan
suggested changes
Jun 28, 2021
github-actions
Bot
removed
the
gpuCI
dillon-cullinan
approved these changes
Jun 28, 2021
thomcom
suggested changes
Jun 29, 2021
thomcom
left a comment
thomcom
left a comment
Contributor
There was a problem hiding this comment.
Is it expected that the clang version fails in gpuCI/cuspatial/check/style now? Glad to approve when tests pass.
Contributor
Author
Yes, once rapidsai/integration#304 is merged, I will retrigger CI for all the Clang11 format PRs and they will light up green (and once missing labels have been added) |
Contributor
Author
|
rerun tests |
1 similar comment
Contributor
Author
|
rerun tests |
thomcom
added
improvement
thomcom
approved these changes
Jul 6, 2021
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for
rapidsai/cuspatialDepends on: rapidsai/integration#304