Skip to content

Updating Clang Version to 11.0.0 - #814

Merged
rapids-bot[bot] merged 7 commits into
rapidsai:branch-21.08from
codereport:clang-11
Jul 6, 2021
Merged

Updating Clang Version to 11.0.0#814
rapids-bot[bot] merged 7 commits into
rapidsai:branch-21.08from
codereport:clang-11

Conversation

@codereport

@codereport codereport commented Jun 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for rapidsai/rmm

Depends on: rapidsai/integration#304

@codereport codereport added 3 - Ready for review Ready for review by team non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jun 25, 2021
@codereport codereport self-assigned this Jun 25, 2021
@codereport
codereport requested review from a team as code owners June 25, 2021 21:22
@codereport
codereport requested review from cwharris and rongou June 25, 2021 21:22
@github-actions github-actions Bot added conda cpp Pertains to C++ code labels Jun 25, 2021
@github-actions github-actions Bot added the gpuCI label Jun 25, 2021
@codereport codereport added the DO NOT MERGE Hold off on merging; see PR for details label Jun 25, 2021
cwharris
cwharris approved these changes Jun 25, 2021
View reviewed changes

@cwharris cwharris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .clang-format
Comment thread ci/checks/style.sh Outdated
Comment thread include/rmm/mr/host/new_delete_resource.hpp
@github-actions github-actions Bot removed the gpuCI label Jun 28, 2021
@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge 4 - Needs Reviewer Waiting for reviewer to review or respond and removed DO NOT MERGE Hold off on merging; see PR for details 3 - Ready for review Ready for review by team 5 - Ready to Merge Testing and reviews complete, ready to merge labels Jun 28, 2021
@codereport codereport mentioned this pull request Jun 28, 2021
Merged
@codereport codereport removed the 4 - Needs Reviewer Waiting for reviewer to review or respond label Jun 28, 2021
@codereport codereport added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 28, 2021
@codereport

codereport commented Jul 6, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

2 similar comments
@codereport

codereport commented Jul 6, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

@codereport

codereport commented Jul 6, 2021

Copy link
Copy Markdown
Contributor Author

rerun tests

@codereport

codereport commented Jul 6, 2021

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 96a905c into rapidsai:branch-21.08 Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rongou rongou rongou approved these changes
+2 more reviewers
@cwharris cwharris cwharris approved these changes
@dillon-cullinan dillon-cullinan dillon-cullinan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@codereport codereport

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge conda cpp Pertains to C++ code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@codereport @rongou @cwharris @dillon-cullinan