Update to Clang Version to 11.0.0 - #304
Merged
Merged
Conversation
dillon-cullinan
approved these changes
Jun 28, 2021
This was referenced Jun 28, 2021
Contributor
Author
|
rerun tests |
Contributor
Author
|
@dillon-cullinan can this be merged now? |
rapids-bot Bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Jul 6, 2021
Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/rmm` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Rong Ou (https://github.com/rongou) - Christopher Harris (https://github.com/cwharris) - Dillon Cullinan (https://github.com/dillon-cullinan) URL: #814
rapids-bot Bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Jul 6, 2021
Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/cuspatial` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Dillon Cullinan (https://github.com/dillon-cullinan) - H. Thomson Comer (https://github.com/thomcom) URL: #426
rapids-bot Bot
pushed a commit
to NVIDIA/cudf
that referenced
this pull request
Jul 7, 2021
This resolves: #5187 PR description copied from: NVIDIA/cuml#3121 Depends on: rapidsai/integration#304 This PR will upgrade the clang version required to 11.0.0 in order to enable us with running clang-tidy on .cu files, while running on cuda v11. See NVIDIA/raft#88 for more details. CI will not pass as the underlying conda-env still uses 8.0.1. Once we have the rapids-build-env meta package updated, this should pass. ----- ### Fixes from Clang 8.0.1 to Clang 11.0.0 (that are observed in delta) * Missing spaces * Incorrect alignment when ternary expression splits across multiple lines * Comment alignment on macros * Fixed where function signatures have line breaks * Aligning macros * Always left align pointer/reference * Don't allow single line for loops ----- To do list: * [x] Update python file * [x] Update conda environment files * [x] Run formatter to apply all changes from upgrading * [x] Add changes from #5187 * [x] Review list of new changes from 8.0.1 to 11; choose which to incorporate * [x] Get working with RAPID compose Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - AJ Schmidt (https://github.com/ajschmidt8) - Nghia Truong (https://github.com/ttnghia) - Mark Harris (https://github.com/harrism) - Dillon Cullinan (https://github.com/dillon-cullinan) URL: #6695
rapids-bot Bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Jul 7, 2021
Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/cugraph` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - Dillon Cullinan (https://github.com/dillon-cullinan) - Chuck Hastings (https://github.com/ChuckHastings) URL: #1688
rapids-bot Bot
pushed a commit
to NVIDIA/cuml
that referenced
this pull request
Jul 9, 2021
Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/cuml` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - William Hicks (https://github.com/wphicks) - AJ Schmidt (https://github.com/ajschmidt8) - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) URL: #4029
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
Follow up PR to: NVIDIA/cudf#6695. Performing the same changes but for `rapidsai/cuml` Depends on: rapidsai/integration#304 Authors: - Conor Hoekstra (https://github.com/codereport) Approvers: - William Hicks (https://github.com/wphicks) - AJ Schmidt (https://github.com/ajschmidt8) - Robert Maynard (https://github.com/robertmaynard) - Dante Gama Dessavre (https://github.com/dantegd) URL: NVIDIA#4029
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is necessary for the following PRs to pass / be merged: