Skip to content

[REVIEW] updated clang version to 11.0.0 - #3121

Closed
teju85 wants to merge 3 commits into
NVIDIA:branch-0.19from
teju85:fea-ext-clang-update
Closed

[REVIEW] updated clang version to 11.0.0#3121
teju85 wants to merge 3 commits into
NVIDIA:branch-0.19from
teju85:fea-ext-clang-update

Conversation

@teju85

@teju85 teju85 commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

This PR will upgrade the clang version required to 11.0.0 in order to enable us with running clang-tidy on .cu files, while running on cuda v11. See NVIDIA/raft#88 for more details.

CI will not pass as the underlying conda-env still uses 8.0.1. Once we have the rapids-build-env meta package updated, this should pass.

@teju85
teju85 requested a review from a team as a code owner November 6, 2020 05:08
@GPUtester

GPUtester commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

This was referenced Nov 6, 2020
Closed
Closed
@teju85

teju85 commented Nov 6, 2020

Copy link
Copy Markdown
Contributor Author

Tagging @codereport , JFYI

@codecov-io

codecov-io commented Nov 6, 2020 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #3121 into branch-0.17 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           branch-0.17    #3121   +/-   ##
============================================
  Coverage        69.38%   69.38%           
============================================
  Files              193      193           
  Lines            14704    14704           
============================================
  Hits             10203    10203           
  Misses            4501     4501

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b29f5...d8b0b81. Read the comment docs.

@codereport codereport mentioned this pull request Nov 6, 2020
Merged
6 tasks
JohnZed
JohnZed requested changes Nov 6, 2020
View reviewed changes

@JohnZed JohnZed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little question, otherwise looks great

Comment thread cpp/test/sg/nvtx_test.cpp
@teju85 teju85 added breaking Breaking change Build or Dep Issues related to building the code or dependencies labels Feb 11, 2021
@mike-wendt

mike-wendt commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

@teju85 FYI this is targeting branch-0.17 it should be updated to target 0.18 or 0.19

@teju85
teju85 changed the base branch from branch-0.17 to branch-0.19 February 11, 2021 04:07
@github-actions

github-actions Bot commented Mar 13, 2021

Copy link
Copy Markdown

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions

github-actions Bot commented May 13, 2021

Copy link
Copy Markdown

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

rapids-bot Bot pushed a commit to NVIDIA/cudf that referenced this pull request Jul 7, 2021
@codereport
Updating Clang Version to 11.0.0 (#6695)
7721819 
This resolves: #5187

PR description copied from: NVIDIA/cuml#3121

Depends on: rapidsai/integration#304

This PR will upgrade the clang version required to 11.0.0 in order to enable us with running clang-tidy on .cu files, while running on cuda v11. See NVIDIA/raft#88 for more details.

CI will not pass as the underlying conda-env still uses 8.0.1. Once we have the rapids-build-env meta package updated, this should pass.

-----

### Fixes from Clang 8.0.1 to Clang 11.0.0 (that are observed in delta)

* Missing spaces
* Incorrect alignment when ternary expression splits across multiple lines
* Comment alignment on macros
* Fixed where function signatures have line breaks
* Aligning macros
* Always left align pointer/reference
* Don't allow single line for loops

-----
To do list:

* [x] Update python file
* [x] Update conda environment files
* [x] Run formatter to apply all changes from upgrading
* [x] Add changes from #5187
* [x] Review list of new changes from 8.0.1 to 11; choose which to incorporate
* [x] Get working with RAPID compose

Authors:
  - Conor Hoekstra (https://github.com/codereport)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Nghia Truong (https://github.com/ttnghia)
  - Mark Harris (https://github.com/harrism)
  - Dillon Cullinan (https://github.com/dillon-cullinan)

URL: #6695
@vyasr

vyasr commented Jul 9, 2021

Copy link
Copy Markdown
Contributor

I believe this has been replaced by #4029 and can be closed.

@dantegd dantegd closed this Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnZed JohnZed JohnZed approved these changes

Assignees

No one assigned

Labels

breaking Breaking change Build or Dep Issues related to building the code or dependencies inactive-30d

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@teju85 @GPUtester @codecov-io @mike-wendt @vyasr @JohnZed @dantegd