Skip to content

refit clean up and refactoring - #4762

Merged
wdykas merged 5 commits into
NVIDIA:mainfrom
wdykas:refit-clean
May 14, 2026
Merged

refit clean up and refactoring#4762
wdykas merged 5 commits into
NVIDIA:mainfrom
wdykas:refit-clean

Conversation

@wdykas

@wdykas wdykas commented May 12, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

  • Refactor of megatron/core/resharding/: dedup across NCCL/Gloo/NVSHMEM (shared base.py), merge
    _plan_multi_dim_lcm + _plan_block_interleaved into _plan_tp
    • Bug fix: _PlanCacheKey now includes src_rank_offset / dst_rank_offset so non-collocated layouts with
      identical sizes don't silently share a plan.
    • Perf: buffer-dtype harmonization + named_refit_tensors + _get_config_tuple cached across refits; MXFP8
      source dequantize prefetched on a side stream; NVSHMEM local copies overlap with the remote pipeline; Gloo
      gains a dedicated copy stream; empty_cache() only when MXFP8 staging happened.
    • Tightened match_local_ops_by_task_id to raise on imbalanced send/recv counts (previously silently dropped
      extras).
    • ~25 new unit tests covering plan cache, copy-service helpers, and non-collocated None-handling; 3
      pre-existing MXFP8 test failures fixed.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@wdykas
wdykas requested review from a team as code owners May 12, 2026 19:54
@copy-pr-bot

copy-pr-bot Bot commented May 12, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft May 12, 2026 19:54
@wdykas

wdykas commented May 12, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e137aa1

@wdykas

wdykas commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 0b0f089

@wdykas

wdykas commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

/claude review

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

William Dykas added 2 commits May 13, 2026 05:58
@wdykas
wdykas marked this pull request as ready for review May 13, 2026 13:40
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team May 13, 2026 13:40
@wdykas

wdykas commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 4aa90b9

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label May 13, 2026
@wdykas

wdykas commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

/claude review

@wdykas wdykas changed the title fri refit clean up and refactoring May 13, 2026

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels May 13, 2026
@wdykas

wdykas commented May 13, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 0259fc9

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25836236302

Merged via the queue into NVIDIA:main with commit 20bf831 May 14, 2026
190 of 191 checks passed
@wdykas
wdykas deleted the refit-clean branch May 14, 2026 03:31
cspades pushed a commit to cspades/Megatron-LM that referenced this pull request May 14, 2026
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
janEbert pushed a commit to janEbert/Megatron-LM that referenced this pull request Jun 2, 2026
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Co-authored-by: William Dykas <wdykas@oci-hsg-cs-001-vscode-03.cm.cluster>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: high Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants