Skip to content

Increase CG cover from max_requests to max_tokens - #4214

Merged
tdene merged 7 commits into
NVIDIA:mainfrom
tdene:tde/increase_cg_limit
May 13, 2026
Merged

Increase CG cover from max_requests to max_tokens#4214
tdene merged 7 commits into
NVIDIA:mainfrom
tdene:tde/increase_cg_limit

Conversation

@tdene

@tdene tdene commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@copy-pr-bot

copy-pr-bot Bot commented Apr 8, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@tdene
tdene marked this pull request as ready for review April 9, 2026 10:37
@tdene
tdene requested review from a team as code owners April 9, 2026 10:37
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 9, 2026
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 9, 2026 10:38
@tdene
tdene marked this pull request as draft April 9, 2026 14:23
@tdene
tdene marked this pull request as ready for review April 13, 2026 04:18
@tdene
tdene force-pushed the tde/increase_cg_limit branch from e0bd412 to 108b24e Compare April 30, 2026 08:43
@tdene
tdene force-pushed the tde/increase_cg_limit branch from 108b24e to 2f6a583 Compare May 5, 2026 09:54
@tdene
tdene force-pushed the tde/increase_cg_limit branch from 2f6a583 to b6d9a9f Compare May 5, 2026 11:14
@tdene

tdene commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 830754b

@tdene

tdene commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

/claude review

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread megatron/core/inference/contexts/dynamic_context.py Outdated
@sidsingh-nvidia

Copy link
Copy Markdown
Contributor

I am torn on if cuda-graphing everything should be opt-in/default/only-thing. This PR makes it the only-thing.

@tdene

tdene commented May 5, 2026

Copy link
Copy Markdown
Contributor Author

I am torn on if cuda-graphing everything should be opt-in/default/only-thing. This PR makes it the only-thing.

If the user does not request CUDA graphs, nothing is graphed. If the user does request CUDA graphed, prior to this PR only some of the steps are graphed, while after this PR everything is graphed.

The only downside I see is the memory consumption of the biggest recorded CUDA graph. But that is already memory consumption that would have to be paid for an eager batch of that size (due to activations). If the user wants to limit their memory consumption they need to specify max_tokens anyway or they might OOM during eager steps. CUDA graphing everything makes it so that the OOM can only happen up-front, instead of unpredictably in the middle of the step.

@tdene
tdene force-pushed the tde/increase_cg_limit branch from d68f099 to 0033cff Compare May 6, 2026 11:42
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label May 11, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels May 12, 2026
@tdene
tdene enabled auto-merge May 12, 2026 23:34
@tdene
tdene added this pull request to the merge queue May 13, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25771832280

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25776760461

@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25782610816

Merged via the queue into NVIDIA:main with commit 72dd053 May 13, 2026
73 of 79 checks passed
@tdene
tdene deleted the tde/increase_cg_limit branch May 13, 2026 08:07
cspades pushed a commit to cspades/Megatron-LM that referenced this pull request May 14, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
svcnvidia-nemo-ci pushed a commit to dimapihtar/Megatron-LM that referenced this pull request Aug 4, 2026
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants