Increase CG cover from max_requests to max_tokens - #4214
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
e0bd412 to
108b24e
Compare
108b24e to
2f6a583
Compare
2f6a583 to
b6d9a9f
Compare
|
/ok to test 830754b |
|
/claude review |
|
I am torn on if cuda-graphing everything should be opt-in/default/only-thing. This PR makes it the only-thing. |
If the user does not request CUDA graphs, nothing is graphed. If the user does request CUDA graphed, prior to this PR only some of the steps are graphed, while after this PR everything is graphed. The only downside I see is the memory consumption of the biggest recorded CUDA graph. But that is already memory consumption that would have to be paid for an eager batch of that size (due to activations). If the user wants to limit their memory consumption they need to specify |
d68f099 to
0033cff
Compare
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25771832280 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25776760461 |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25782610816 |
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com> Signed-off-by: Dmytro Pykhtar <dpykhtar@nvidia.com>
What does this PR do ?
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.