Sync Develop 2024-12-12 to dev/ufs-weather-model #1381
Merged
JessicaMeixner-NOAA merged 30 commits intoMar 19, 2025
Merged
Conversation
…ST4 code (NOAA-EMC#1124) Co-authored-by: Fabrice Ardhuin <fabrice.ardhuin@ifremer.fr>
Co-authored-by: Denise Worthen <denise.worthen@noaa.gov>
…ompiled with the OMPG switch. Also fixes truncation of build.log when running run_cmake_build. (NOAA-EMC#1191) * Added screen output showing number of threads when OMP enabled. * update build to get more info in logs (NOAA-EMC#46) --------- Co-authored-by: Jessica Meixner <jessica.meixner@noaa.gov>
Co-authored-by: Fabrice Ardhuin <fabrice.ardhuin@ifremer.fr>
Co-authored-by: Nicholas Szapiro <149816583+NickSzapiro-NOAA@users.noreply.github.com>
…OAA-EMC#1230) --------- Co-authored-by: Edward Hartnett <edward.hartnett@noaa.gov> Co-authored-by: Matthew Masarik <Matthew.Masarik@noaa.gov>
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@clogin02.cactus.wcoss2.ncep.noaa.gov>
Co-authored-by: Ty Hesser <thesser1@gmail.com> Co-authored-by: Tyler James Hesser <thesser1@carpenter09.hsn.ex4000.erdc.hpc.mil>
Based on Meylan Horvat Bitz and Bennetts, Ocean Modelling, 2021. Co-Authors include: Erin Thomas, Cecilia Bitz, David Bailey, Nick Szapiro. Co-authored-by: Erin Thomas <ac.ethomas@chrlogin1.lcrc.anl.gov>
Conflicts: model/inp/ww3_ounf.inp model/src/w3gdatmd.F90 model/src/w3gridmd.F90 model/src/w3initmd.F90 model/src/w3iogomd.F90 model/src/w3iogrmd.F90 model/src/w3sic4md.F90 model/src/w3src4md.F90
This was referenced Feb 24, 2025
Collaborator
Author
MatthewMasarik-NOAA
approved these changes
Feb 26, 2025
Contributor
MatthewMasarik-NOAA
left a comment
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
Code review
Pass
Testing
Pass
UFS RTs run with no failures.
Collaborator
Author
|
This PR's UFS PR (ufs-community/ufs-weather-model#2621) is now combined into ufs-community/ufs-weather-model#2503 |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Next segment of syncing develop to dev/ufs-weather-model, no answer changes.
Description
Merge the next segment of develop to dev/ufs-weather-model, which has no answer changes.
Issue(s) addressed
Commit Message
Sync Develop 2024-12-12 to dev/ufs-weather-model
(Note to self: Don't forget to use merge commit, not squash merge)
Check list
Testing
/scratch1/NCEPDEV/climate/Jessica.Meixner/PR_WW3/syncdev2ufs/WW3_input_01
Testing: https://github.com/JessicaMeixner-NOAA/ufs-weather-model/tree/WW3_nochangesync
RegressionTests_hera.log
The test_changes.list file is blank.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?): matrix is not run as these were run in the develop branch.
Have the matrix regression tests been run (if yes, please note HPC and compiler)? no used ufs-wetaher-model.
Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):