Fix build 'remarks'#1201
Merged
JessicaMeixner-NOAA merged 4 commits intoMar 13, 2024
Merged
Conversation
JessicaMeixner-NOAA
approved these changes
Mar 13, 2024
Collaborator
JessicaMeixner-NOAA
left a comment
There was a problem hiding this comment.
Addresses the remarks seen when building with a particular switch file. The overall number of remarks are now reduced.
There are changes in outputs but not actual answer changes with this PR. There are too many diffs to list but the logs are attached:
MatthewMasarik-NOAA
added a commit
to MatthewMasarik-NOAA/WW3
that referenced
this pull request
Mar 26, 2024
sbanihash
pushed a commit
to sbanihash/WW3
that referenced
this pull request
Mar 26, 2024
4 tasks
MatthewMasarik-NOAA
added a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: saeideh banihashemi <saeideh.banihashemi@clogin02.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: Matthew Masarik <86749872+MatthewMasarik-NOAA@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Resolves compiler '
remark's from building thedevelopbranch.Description
remarks. This involved enforcing the suggested width,W>=D+7, by choosing the minimal change,W=D+7. This PR is for thedevelopbranch. After acceptance it will be PR'd to thedev/ufs-weather-modelbranch to resolve the WW3 portion of Compiler warnings may not be suppressed ufs-community/ufs-weather-model#1984. Theremarks fixed fordevelopare shown below. Note, there is one additional remark to be fixed in thedev/ufs-weather-modelbranch.Please also include the following information:
Issue(s) addressed
Commit Message
Fix compiler build 'remark's
Check list
Testing
hera/intel.Verification of fix