Fix incorrect depth scaling in SMC regtests

[ukmo-ccbunney]

Pull Request Summary

A recent change to the SMC code (#1192) requires a change to the ww3_tp2.10 and ww3_tp2.16 regressions tests to correctly scale the input depth field.

Description

The following entry is added to the ww3_grid.nml files for the SMC regtests to explicitly set the depth scaling value:

&DEPTH_NML
  DEPTH%SF = -1.0
/

This is required as the changes made in #1192 change the default depth scaling value (variable VSC in the code) from -1.0 to 1.0. This does not affect the regtests if using the ww3_grid.inp files as this value is mandatory in the INP files.

Issue(s) addressed

• fixes VSC value needs updating for SMC regtests #1240

Commit Message

Add depth scaling value to SMC regression tests.

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• [N/A] If a version number update is required, checked the updating version number checklist.
• [N/A ] If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
  • Regression tests.
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Yes
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Yes - Linux, GNU fortran,
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • The *.nc files created when using NML input in ww3_tp2.10 and ww3_tp2.16 will now be correct.
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):
  TBC

[MatthewMasarik-NOAA]

Sorry for the delay, testing is in progress.

[MatthewMasarik-NOAA]

Code review
Pass

Testing
Pass

Only the known non-b4b's differ.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (8 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (6 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (13 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)
 
**********************************************************************
************************ identical cases *****************************
**********************************************************************

• matrixCompSummary.txt
• matrixCompFull.txt
• matrixDiff.txt

[MatthewMasarik-NOAA]

Thanks @ukmo-ccbunney!