Initial drying of cells for SMC grid

[ukmo-ccbunney]

Pull Request Summary

Adds functionality to correctly set cells as "dry" when reading in the SMC depth data via ww3_grid

Description

When the SMC grid bottom depths are read in via ww3_grid, the minimum water depth is always set to DMIN and cells are never initially set to "dry"

This update provides similar functionality to the regular grid where depths below the ZLIM cut-off depth have the status set to "dry". This only affects the initial status of the cells when the depths are read in via ww3_grid.

Furthermore. the depths are no longer set to a minimum of DMIN in ww3_grid - this calculation is performed elsewhere in the code, as per the regular grid. This does result in a change in the mod_def.ww3 files for the SMC grid regression tests as the raw bottom depths are stored whereas previously any depth < DMIN would have a value of DMIN stored.

The dpt output field in ww3.201109.nc of regtest ww3_tp2.14/OASACM6 is similarly affected by this change.

Issue(s) addressed

N/A

Commit Message

Provide initial drying of cells with depth < ZLIM for SMC grid.

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? Regression tests
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? Yes; Cray XC; GNU Fortran
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)

Ignoring the usual non-b4b regtest, differences in the regtests are shown below.
All differences are expected and are a result of the change in minimum depth stored in the mod_def.ww3 files.

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_09/./work_MPI                     (3 files differ)  
mww3_test_09/./work_MPI_ASCII                     (6 files differ)
ww3_tp2.10/./work_MPI                     (1 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (1 files differ)
ww3_tp2.14/./work_OASACM6                     (3 files differ)
ww3_tp2.16/./work_MPI                     (1 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (1 files differ)

[ukmo-jianguo-li]

I have looked at the changes in w3gridmd.F90 for this update and they look fine to me. I approve these changes.

[ukmo-jianguo-li]

The changes look fine to me. Thanks for Chris to copy these changes into the develop branch. I approve these changes.
Jian-Guo

[JessicaMeixner-NOAA]

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (9 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (8 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (12 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_09/./work_MPI                     (3 files differ)
mww3_test_09/./work_MPI_ASCII                     (6 files differ)
ww3_tp2.10/./work_MPI                     (1 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (8 files differ)
ww3_tp2.14/./work_OASACM6                     (3 files differ)
ww3_tp2.16/./work_MPI                     (1 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (5 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt