Fix: Gnu regtest CI failure#1253
Merged
JessicaMeixner-NOAA merged 5 commits intoJun 24, 2024
Merged
Conversation
Contributor
Author
|
I updated the header Description and PR status. @CarstenHansen, let us know if this fix works for you. |
Contributor
|
Yes, @MatthewMasarik-NOAA, your fix works for me on Github Actions without complains. |
JessicaMeixner-NOAA
approved these changes
Jun 24, 2024
Collaborator
|
Thank you @MatthewMasarik-NOAA for the quick fix for this, and thank you @CarstenHansen for confirming this works! |
Contributor
Author
Perfect, thanks for confirming @CarstenHansen. |
ukmo-ccbunney
added a commit
to ukmo-waves/WW3
that referenced
this pull request
Sep 4, 2024
* origin/develop: Enable doxygen documentation in the cmake build system (NOAA-EMC#1281) Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266) Add depth scaling value to SMC regression tests. (NOAA-EMC#1264) Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263) Fix code stability issue in ww3_outp (NOAA-EMC#1258) Fix GNU regtest CI failure (NOAA-EMC#1253)
ukmo-ccbunney
added a commit
to ukmo-waves/WW3
that referenced
this pull request
Sep 4, 2024
* origin/develop: Enable doxygen documentation in the cmake build system (NOAA-EMC#1281) Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266) Add depth scaling value to SMC regression tests. (NOAA-EMC#1264) Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263) Fix code stability issue in ww3_outp (NOAA-EMC#1258) Fix GNU regtest CI failure (NOAA-EMC#1253)
ukmo-ccbunney
added a commit
to ukmo-waves/WW3
that referenced
this pull request
Sep 4, 2024
* feature/gpu/w3srce_refactor: Enable doxygen documentation in the cmake build system (NOAA-EMC#1281) Simplify MPI ifdefs in subroutine W3MPIO (NOAA-EMC#1266) Add depth scaling value to SMC regression tests. (NOAA-EMC#1264) Updates to NCEP regtests for Orion Rocky9 OS(NOAA-EMC#1263) Fix code stability issue in ww3_outp (NOAA-EMC#1258) Fix GNU regtest CI failure (NOAA-EMC#1253) Add option to use NetCDF output instead of binary for point output (NOAA-EMC#1230)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Provides a fix for the Gnu github workflow
regtest_gnu.ymladded in commit 629d27a.Description
keyregtest_gnucontains a working regtest w/ MPI running on Github Actions, which is a big milestone itself. Thanks to @edwardhartnett who did all the heavy lifting.Please also include the following information:
Issue(s) addressed
Commit Message
Fix GNU regtest CI failure
Check list
Testing