Update NCEP regtests for Orion: Rocky9 OS

[MatthewMasarik-NOAA]

Pull Request Summary

Makes the necessary updates to the NCEP regtests for Orion to account for OS upgrade to Rocky9. This also includes a related bug fix.

Description

Contains the following:

• Update to module environment for Rocky9 OS (based on current UFS/modulefiles: ufs_common.lua, ufs_orion.intel.lua).
• New Parmetis built with updated modules (Note: the path remains the same, but a new build is in place).
• Bug fix associated with a null assignment to variable batchq in matrix_cmake_ncep.
• Text editor auto cleanup of trailing whitespace.

Please also include the following information:

• Add any suggestions for a reviewer
  • @JessicaMeixner-NOAA
• Mention any labels that should be added:
  • bug, enhancement
• Are answer changes expected from this PR? Please describe the changes and the reason why in addition to which of the following labels would apply:
  • No change to answers (out_grd, out_pnt), though two tests have files that differ described in the Testing section.

Issue(s) addressed

• Please list any issues associated with this PR, including those the PR will fix/close. For example:

• fixes Update/fix NCEP regtests for Rocky9 OS on Orion #1262

Commit Message

Updates to NCEP regtests for Orion Rocky9 OS

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• [na] If a version number update is required, checked the updating version number checklist.
• [na] If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested?
  • Two sets of matrix regression tests: develop vs. pr, and pr vs. pr.
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • No. Regtests are not needed for HPC center software changes.
• Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Orion / intel.
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • develop vs. PR
    • ww3_tp2.1 - netcdf output. An issue will be created to track these differences.
    • ww3_ufs1.1/unstr - only due to added switch, BIN2NC, in netcdf output.
  • PR vs. PR
    • Only known non-b4b's.
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

develop vs. PR branch

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (19 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (16 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (26 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (20 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.1/./work_PR1                     (1 files differ)
ww3_tp2.1/./work_PR1_MPI                     (1 files differ)
ww3_tp2.1/./work_PR3_UNO                     (1 files differ)
ww3_tp2.1/./work_PR2_UQ                     (1 files differ)
ww3_tp2.1/./work_PR3_UQ                     (1 files differ)
ww3_tp2.1/./work_PR3_UQ_MPI                     (1 files differ)
ww3_tp2.1/./work_PR3_UNO_MPI                     (1 files differ)
ww3_tp2.1/./work_PR2_UNO                     (1 files differ)
ww3_tp2.1/./work_PR2_UQ_MPI                     (1 files differ)
ww3_tp2.1/./work_PR2_UNO_MPI                     (1 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.1/./work_unstr_c                     (1 files differ)
ww3_ufs1.1/./work_unstr_b                     (1 files differ)
ww3_ufs1.1/./work_unstr_a                     (1 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)
 
**********************************************************************
************************ identical cases *****************************
**********************************************************************

• dev.matrixCompSummary.txt
• dev.matrixCompFull.txt
• dev.matrixDiff.txt

PR vs. PR

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR2_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2                     (12 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.16/./work_MPI_OMPH                     (4 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)
 
**********************************************************************
************************ identical cases *****************************
**********************************************************************

• pr.matrixCompSummary.txt
• pr.matrixCompFull.txt
• pr.matrixDiff.txt

[MatthewMasarik-NOAA]

Ready for review now, @JessicaMeixner-NOAA

[JessicaMeixner-NOAA]

@MatthewMasarik-NOAA thanks - I think you correctly pointed out some really strange behavior for tp2.1. Let's open an issue for that. I'll run the regtests one more time and then we can merge this in but I think it's likely good to have the tp2.1 differences well documented because I don't think what's happening now is correct.

[MatthewMasarik-NOAA]

Issue #1267

[JessicaMeixner-NOAA]

I obtained the same results as @MatthewMasarik-NOAA

Issue #1267 is a concern that should be further investigated particularly as the answers on orion are different than what was previously gotten on orion and what we get on hera. However, this will enable us to otherwise use orion, so we can merge.