Skip to content

[Develop] mina-verify-packaged-fork-config checks the hashes against a block from the archive #15455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Apr 4, 2024
Merged

[Develop] mina-verify-packaged-fork-config checks the hashes against a block from the archive #15455

merged 44 commits into from
Apr 4, 2024

Conversation

@georgeee
Copy link
Member

@georgeee georgeee commented Apr 3, 2024

Port #15400 to develop.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

emberian and others added 27 commits March 27, 2024 19:53
@emberian
mina-verify-packaged-fork-config checks the hashes against a block fr…
34ed2b1 
…om the archive
@emberian
runtime_genesis_ledger: output an 'oldhash' for input ledgers
e1d3aea
@emberian
verify-packaged-fork-config: use the new oldhash
8bb1efc
@emberian
ensure packages have required $PATH constituents
16fec5b
@emberian
gotta do the cooking by the book
00a025c
@emberian
whoops
1f1a2b3
@georgeee
Use ledger_depth=20 for old hash
7914260
@georgeee
Support v1 format for ledger hash generation
cd20af0 
Problem: set_verification_key permission format was changed to include
tx_version which changed the algorithm for ledger hash verification.
This obstructs attempts to generate old-network-format hashes.

Solution: provide an option to omit tx version of set_verification_key
permission when computing the ledger hash.
@georgeee
Revert "Support v1 format for ledger hash generation"
0664830 
This reverts commit cd20af0.
@georgeee
Revert "Use ledger_depth=20 for old hash"
65823f8 
This reverts commit 7914260.
@georgeee
Revert changes to runtime_genesis_ledger
b2687fb
@georgeee
Update script with use of mina-create-legacy-genesis
17e02fb
@emberian
try this approach
2b7fabe
@georgeee
Merge branch 'berkeley' into feat/verify-epoch-ledgers-too
be5079c
@emberian
install mina-create-legacy-ledger from #15433
e88c7e4
@emberian
cleanup extra stuff that happened differently already upstream
377f5a7
@emberian
these are probably aesthetically unnecessary despite helping >1 person
84cf8b1
@emberian
ok, mina-docker gets that one
6441ccb
@emberian
typo
875c00c
@deepthiskumar
devnet stop slots
e2446fe
@dkijania
use correct name in mina-create-legacy-genesis
1235243
@dkijania
Merge branch 'berkeley' into feat/verify-epoch-ledgers-too
263c7b6
@georgeee
Merge pull request #15446 from MinaProtocol/georgeee/fix-hf-unit-test…
ab1462a 
…-2024-apr03

Fix HF unit test after compatible update
@georgeee
Merge pull request #15448 from MinaProtocol/georgeee/update-nix-berke…
e978e08 
…ley-migration

Update nix files to build berkeley migration tools
@georgeee
Merge branch 'berkeley' into feat/verify-epoch-ledgers-too
2972ab4
@georgeee
Merge remote-tracking branch 'origin/compatible' into feat/verify-epo…
e344310 
…ch-ledgers-too
@georgeee
Merge branch 'feat/verify-epoch-ledgers-too' into HEAD
836690c
@georgeee georgeee requested review from a team as code owners April 3, 2024 17:07
@georgeee
Copy link
Member Author

georgeee commented Apr 3, 2024

!ci-build-me

mrmr1993 and others added 14 commits April 3, 2024 19:09
@mrmr1993
Merge branch 'berkeley' into devnet-hf-stop-slots-BERKELEY
70ec313
@deepthiskumar
Merge pull request #15443 from MinaProtocol/devnet-hf-stop-slots
7f7ff86 
Devnet HF stop slots
@georgeee
Fix a typo
3d48ddd
@emberian
brace expansion only happens outside double quotes
c1f7046
@emberian
Update export-git-env-vars.sh
b0ee0ab
@mrmr1993
Merge pull request #15459 from MinaProtocol/emberian-patch-2
6be768d 
compatible: support devnet channel
@mrmr1993
Merge branch 'compatible' into devnet-hf-stop-slots-BERKELEY
9eee212
@mrmr1993
Merge pull request #15457 from MinaProtocol/devnet-hf-stop-slots-BERK…
3596e67 
…ELEY

[berkeley] Devnet HF stop slots #15443
@georgeee
Nits
abc8253
@georgeee
Split the jq-based check to two separate checks
84d4804
@georgeee
Fix expression extracting info from precomputed block
4622105
@georgeee
Fix for "Assert corrupted packaged artifacts are unverifiable"
45d56b0
@georgeee
Silence noise in re-attempting to export staged ledger
b733cf9
@georgeee
Merge branch 'berkeley' into feat/verify-epoch-ledgers-too
34064ef
@georgeee georgeee mentioned this pull request Apr 4, 2024
Merged
@georgeee
Merge remote-tracking branch 'origin/feat/verify-epoch-ledgers-too' i…
191d8ac 
…nto feat/verify-epoch-ledgers-too-to-develop
@georgeee
Copy link
Member Author

georgeee commented Apr 4, 2024

!ci-build-me

@georgeee
Copy link
Member Author

georgeee commented Apr 4, 2024

!ci-build-me

@georgeee georgeee merged commit 75c65d9 into develop Apr 4, 2024
@georgeee georgeee deleted the feat/verify-epoch-ledgers-too-to-develop branch April 4, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkijania dkijania dkijania approved these changes

+1 more reviewer

@emberian emberian emberian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@georgeee @emberian @dkijania @deepthiskumar @mrmr1993