Skip to content

Conversation

@georgeee
Copy link
Member

@georgeee georgeee commented Apr 3, 2024

Explain your changes:

  • One of patches that was applied to compatible was merged to compatible

Explain how you tested your changes:

  • Ran the HF unit test

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested review from a team as code owners April 3, 2024 10:15
@georgeee
Copy link
Member Author

georgeee commented Apr 3, 2024

!ci-build-me

@georgeee
Copy link
Member Author

georgeee commented Apr 3, 2024

!ci-nightly-me

@georgeee
Copy link
Member Author

georgeee commented Apr 3, 2024

@ghost-not-in-the-shell
Copy link
Contributor

Are the patches for caqti-upgrade?

@georgeee
Copy link
Member Author

georgeee commented Apr 3, 2024

Are the patches for caqti-upgrade?

This PR removes scripts/hardfork/localnet-patches/compatible-2.patch that contained what PR #15433 merged.

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@georgeee georgeee merged commit ab1462a into berkeley Apr 3, 2024
@georgeee georgeee deleted the georgeee/fix-hf-unit-test-2024-apr03 branch April 3, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants