Skip to content

Conversation

@georgeee
Copy link
Member

@georgeee georgeee commented Apr 3, 2024

Apply caqti-upgrade-plus-archive-init-speedup.patch to sources before building the packages.

Explain how you tested your changes:

  • Built berkeley package with nix build .?submodules=1#mainnet-caqti-patched.berkeley_migration
  • Ran incremental migration pass with mina-berkeley-migration-script incremental -g mainnet.json -b mina_network_block_data -bs 50 -n mainnet -s postgres://mina@localhost:5440/archive_feb19 -t postgres://mina@localhost:5440/migrated -r migration-checkpoint-497736.json

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

@georgeee georgeee requested a review from a team as a code owner April 3, 2024 12:06
@georgeee georgeee changed the title Update nix files to build berkeley migration tools [Draft] Update nix files to build berkeley migration tools Apr 3, 2024
@georgeee georgeee force-pushed the georgeee/update-nix-berkeley-migration branch from 33368f4 to 7edd030 Compare April 3, 2024 13:21
@georgeee georgeee changed the title [Draft] Update nix files to build berkeley migration tools Update nix files to build berkeley migration tools Apr 3, 2024

devnet = wrapMina self.devnet-pkg { };

berkeley-migration-pkg = self.mina-dev.overrideAttrs (s: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one reason we separated these out in the debs was overlapping package conflicts. but I imagine that's simply not a problem with nix.

the only requirement is then to ~always disambiguate which thing you want packages from? vs adding to user environment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was in this form before because different DUNE_PROFILE was used, but this is not the case anymore.

@georgeee
Copy link
Member Author

georgeee commented Apr 3, 2024

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@georgeee georgeee merged commit e978e08 into berkeley Apr 3, 2024
@georgeee georgeee deleted the georgeee/update-nix-berkeley-migration branch April 3, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants