mina-verify-packaged-fork-config checks the hashes against a block from the archive #15400
Conversation
|
!ci-build-me |
emberian
force-pushed
the
feat/verify-epoch-ledgers-too
branch
from
174c5c6 to
34ed2b1
Compare
Problem: set_verification_key permission format was changed to include tx_version which changed the algorithm for ledger hash verification. This obstructs attempts to generate old-network-format hashes. Solution: provide an option to omit tx version of set_verification_key permission when computing the ledger hash.
| mkdir -p "$workdir" | ||
| mkdir -p "$workdir/ledgers" | ||
| mkdir -p "$workdir/ledgers-backup" | ||
| mkdir -p "$workdir/keys" |
There was a problem hiding this comment.
Why not write above commands in one line?
mkdir -p "$workdir"/{ledgers,ledgers-backup,keys}
There was a problem hiding this comment.
when there was only one .... the thought had yet to occur to me that there would be three.
emberian
force-pushed
the
feat/verify-epoch-ledgers-too
branch
from
3e9a230 to
2b7fabe
Compare
|
@emberian looks like there is unrelated code for debian dependencies selected is it intended |
dockerfiles/Dockerfile-mina-daemon
Outdated
| && echo "deb [trusted=yes] http://packages.o1test.net $deb_codename $deb_release" > /etc/apt/sources.list.d/o1.list \ | ||
| && apt-get update --quiet --yes \ | ||
| && apt-get install --quiet --yes --allow-downgrades "${MINA_DEB}=$deb_version" \ | ||
| && apt-get install --quiet --yes --allow-downgrade "mina-create-legacy-ledger=1.4.0beta2-georgeee-port-runtime-genesis-ledger-to-compatible-9a494bf" \ |
There was a problem hiding this comment.
I don't know if this is a good idea to depend on personal branch debian
There was a problem hiding this comment.
still waiting on https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/1750 to be able to update it
the other problem is that we need to ensure that there is a copy of this package available for every channel, otherwise the container will fail to build.
the alternative seems like a weird type of buildkite job that would have to depend on two branches simultaneously.
There was a problem hiding this comment.
@emberian you can use version: 1.4.0beta2-compatible-97f7d8c
There was a problem hiding this comment.
I believe it's already being used
|
!ci-build-me |
|
!ci-build-me |
1 similar comment
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!ci-build-me |
|
!approved-for-mainnet |
| , extraEnv = [ "CONFIG_JSON_GZ_URL=\$CONFIG_JSON_GZ_URL", "NETWORK_NAME=\$NETWORK_NAME" ] | ||
| -- an account with this balance seems present in many ledgers? | ||
| } "curl \$CONFIG_JSON_GZ_URL > config.json.gz && gunzip config.json.gz && sed -e '0,/20.000001/{s/20.000001/20.01/}' -i config.json && (mina-verify-packaged-fork-config \$NETWORK_NAME config.json /workdir/verification && false)" | ||
| } "curl \$CONFIG_JSON_GZ_URL > config.json.gz && gunzip config.json.gz && sed -e '0,/20.000001/{s/20.000001/20.01/}' -i config.json && ! (mina-verify-packaged-fork-config \$NETWORK_NAME config.json /workdir/verification)" |
There was a problem hiding this comment.
d'oh the laws of material implication strike again
"Ledger validation tool"
Develop twin: #15455
Test plan: