Skip to content

Conversation

@georgeee
Copy link
Member

@georgeee georgeee commented Apr 1, 2024

Explain your changes:

  • Port changes from berkeley to allow for runtime_genesis_ledger tool to generate hashes json file with ledger hashes of config file being used as an input
  • Generate a new debian package with runtime_genesis_ledger corresponding to mainnet's version (hence names as create "legacy" ledger)

Explain how you tested your changes:

  • Part of HF unit test, tested there

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@georgeee georgeee requested a review from a team as a code owner April 1, 2024 18:28
@georgeee
Copy link
Member Author

georgeee commented Apr 1, 2024

!ci-build-me

@georgeee georgeee requested a review from a team as a code owner April 1, 2024 19:28
@georgeee
Copy link
Member Author

georgeee commented Apr 1, 2024

!ci-build-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@deepthiskumar deepthiskumar merged commit 97f7d8c into compatible Apr 2, 2024
@deepthiskumar deepthiskumar deleted the georgeee/port-runtime_genesis_ledger-to-compatible branch April 2, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants