Skip to content

Conversation

@georgeee
Copy link
Member

@georgeee georgeee commented Apr 4, 2024

Explain your changes:

  • Use the correct value of staged ledger hash in the .ledger.hash field
  • Do not inherit fields of genesis ledger (name, balances, num_accounts, hash)
  • Make runtime_genesis_ledger more strict in accepting fork configs

Explain how you tested your changes:

  • Re-run HF unit test
  • Re-run last step of mainnet migration with updated hash
  • Validate generated fork config manually

PR group:

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? None

georgeee added 2 commits April 4, 2024 13:04
* Make runtime_genesis_ledger stricter in accepting configs
* Remove nonsense from runtime_config when loading epoch_data ledgers
@georgeee georgeee requested a review from a team as a code owner April 4, 2024 11:23
@georgeee
Copy link
Member Author

georgeee commented Apr 4, 2024

!ci-build-me

@deepthiskumar
Copy link
Member

!ci-build-me

@deepthiskumar
Copy link
Member

!ci-nightly-me

@deepthiskumar
Copy link
Member

!approved-for-mainnet

@georgeee georgeee merged commit e1619db into compatible Apr 9, 2024
@georgeee georgeee deleted the georgeee/fix-fork-config-export-apr2024 branch April 9, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants