-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7.2.0 #6651
Merged
Merged
7.2.0 #6651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…expected crashes approving (#6623) * fix: Support Decimal Comma for Token Custom Spend Cap (#6637) * should replace decimal comma to decimal dots * check that value is a number before saving * token decimal value should not be greater than token decimal * improve test ids * improve variable naming * rebased to main
* token allowance flow * failing test * lint * moved url * updated copy changes * undefined to null * rebased to release
* isCustomSpendInputValid check updates only on erc20 tokens * update feedback
…s or click Edit (#6711) * keep inputted token spend value when present * edit spend value should not set dapp default value
* feat: trigger qrsigning modal using approval controller * fix: use approval request to control QR modal * remove QRState usage * use approval request to control QR modal for tx * fix lint * add early return on qr signing modal --------- Co-authored-by: OGPoyraz <[email protected]> Co-authored-by: Vinicius Stevam <[email protected]> Co-authored-by: Vinicius Stevam <[email protected]>
* Fix deeplink intrinsic gas issue Signed-off-by: Olusegun Akintayo <[email protected]> * fix comment Signed-off-by: Olusegun Akintayo <[email protected]> * destructure suggested gas limit Signed-off-by: Olusegun Akintayo <[email protected]> --------- Signed-off-by: Olusegun Akintayo <[email protected]>
* New Crowdin translations by Github Action (#6649) * New Crowdin translations by Github Action * format to trigger CI --------- Co-authored-by: metamaskbot <[email protected]> Co-authored-by: sethkfman <[email protected]> * fix formating issue --------- Co-authored-by: MetaMask Bot <[email protected]> Co-authored-by: metamaskbot <[email protected]>
* send chain id to signature controller in hexadecimal format * to hexadecimal chain id on signature controller * Revert "send chain id to signature controller in hexadecimal format" This reverts commit 2a68c6a.
Signed-off-by: Olusegun Akintayo <[email protected]>
* fix: patch balance retrieval in AccountTrackerController return an error in case of balance query timeout instead of the default zero balance * fix for back balance retrieval * fix return value this was not the right fix previously... * remove unused result variable --------- Co-authored-by: sethkfman <[email protected]>
Co-authored-by: João Loureiro <[email protected]>
chrisleewilcox
approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! |
metamaskbot
added
the
release-7.3.0
Issue or pull request that will be included in release 7.3.0
label
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release candidate for version 7.2.0.