Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.2.0 #6651

Merged
merged 18 commits into from
Jul 5, 2023
Merged

7.2.0 #6651

merged 18 commits into from
Jul 5, 2023

Conversation

github-actions[bot]
Copy link
Contributor

This is the release candidate for version 7.2.0.

@github-actions
Copy link
Contributor Author

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

tommasini and others added 15 commits June 23, 2023 16:10
…expected crashes approving (#6623)

* fix: Support Decimal Comma for Token Custom Spend Cap (#6637)

* should replace decimal comma to decimal dots

* check that value is a number before saving

* token decimal value should not be greater than token decimal

* improve test ids

* improve variable naming

* rebased to main
* token allowance flow

* failing test

* lint

* moved url

* updated copy changes

* undefined to null

* rebased to release
* isCustomSpendInputValid check updates only on erc20 tokens

* update feedback
…s or click Edit (#6711)

* keep inputted token spend value when present

* edit spend value should not set dapp default value
* feat: trigger qrsigning modal using approval controller

* fix: use approval request to control QR modal

* remove QRState usage

* use approval request to control QR modal for tx

* fix lint

* add early return on qr signing modal

---------

Co-authored-by: OGPoyraz <[email protected]>
Co-authored-by: Vinicius Stevam <[email protected]>
Co-authored-by: Vinicius Stevam <[email protected]>
* Fix deeplink intrinsic gas issue

Signed-off-by: Olusegun Akintayo <[email protected]>

* fix comment

Signed-off-by: Olusegun Akintayo <[email protected]>

* destructure suggested gas limit

Signed-off-by: Olusegun Akintayo <[email protected]>

---------

Signed-off-by: Olusegun Akintayo <[email protected]>
* New Crowdin translations by Github Action (#6649)

* New Crowdin translations by Github Action

* format to trigger CI

---------

Co-authored-by: metamaskbot <[email protected]>
Co-authored-by: sethkfman <[email protected]>

* fix formating issue

---------

Co-authored-by: MetaMask Bot <[email protected]>
Co-authored-by: metamaskbot <[email protected]>
* send chain id to signature controller in hexadecimal format

* to hexadecimal chain id on signature controller

* Revert "send chain id to signature controller in hexadecimal format"

This reverts commit 2a68c6a.
* fix: patch balance retrieval in AccountTrackerController

return an error in case of balance query timeout instead of the default zero balance

* fix for back balance retrieval

* fix return value

this was not the right fix previously...

* remove unused result variable

---------

Co-authored-by: sethkfman <[email protected]>
@sethkfman sethkfman marked this pull request as ready for review July 5, 2023 20:27
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

22.9% 22.9% Coverage
0.0% 0.0% Duplication

@chrisleewilcox chrisleewilcox merged commit 19457c9 into main Jul 5, 2023
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
@metamaskbot metamaskbot added the release-7.3.0 Issue or pull request that will be included in release 7.3.0 label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-7.3.0 Issue or pull request that will be included in release 7.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants