Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): detox: change view ID back to Security & Privacy view to scroll down to bottom #6669

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix(test): detox: change view ID back to Security & Privacy view to scroll down to bottom #6669

merged 1 commit into from
Jun 21, 2023

Conversation

chrisleewilcox
Copy link
Contributor

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
detox test e2e/specs/onboarding-wizard-opt-in.spec.js was failing because wrong testID was used on Security & Privacy view to swipe down to the bottom of the view.

Working with changes:
image

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@chrisleewilcox chrisleewilcox added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) release-7.2.0 Issue or pull request that will be included in release 7.2.0 labels Jun 21, 2023
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner June 21, 2023 22:47
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cortisiko
cortisiko approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox added QA Passed A successful QA run through has been done E2E and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

46.2% 46.2% Coverage
0.0% 0.0% Duplication

@chrisleewilcox chrisleewilcox merged commit a779bd9 into release/7.2.0 Jun 21, 2023
@chrisleewilcox chrisleewilcox deleted the detox/fix-scrollToBottomOfView branch June 21, 2023 23:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cortisiko cortisiko cortisiko approved these changes

Assignees
No one assigned
Labels
E2E QA Passed A successful QA run through has been done release-7.2.0 Issue or pull request that will be included in release 7.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisleewilcox @cortisiko