fix: Approve button is always disabled for ERC721 tokens #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3 tasks
blackdevelopa
added
needs-dev-review
digiwand
reviewed
Jun 21, 2023
digiwand
reviewed
Jun 21, 2023
jpuri
approved these changes
Jun 23, 2023
seaona
added
needs-qa
blackdevelopa
force-pushed
the
fix_approve_erc721_rc
branch
from
13df3ed
to
a42bdc9
Compare
|
Kudos, SonarCloud Quality Gate passed! |
seaona
removed
the
needs-qa
|
From QA looks good too! I can see how the issue has been fixed @blackdevelopa great work 🔥 approve-erc721-button.mp4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,
1. What is the reason for the change?
2. What is the improvement/solution?
Screenshots/Recordings
Screen.Recording.2023-06-21.at.12.25.21.mov
Issue
Progresses #6654
Checklist