-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trigger qrsigning modal using approval controller #6212
Merged
OGPoyraz
merged 11 commits into
main
from
feat/783-trigger-modal-using-approval-controller-on-qr-signing
Jun 23, 2023
Merged
feat: trigger qrsigning modal using approval controller #6212
OGPoyraz
merged 11 commits into
main
from
feat/783-trigger-modal-using-approval-controller-on-qr-signing
Jun 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OGPoyraz
commented
Apr 19, 2023
OGPoyraz
force-pushed
the
feat/783-trigger-modal-using-approval-controller-on-qr-signing
branch
2 times, most recently
from
April 19, 2023 10:15
5be4a92
to
3bdd40b
Compare
vinistevam
force-pushed
the
feat/783-trigger-modal-using-approval-controller-on-qr-signing
branch
from
May 3, 2023 17:59
3bdd40b
to
6b8fa7e
Compare
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
force-pushed
the
feat/783-trigger-modal-using-approval-controller-on-qr-signing
branch
from
May 4, 2023 11:43
16fe025
to
74e0b32
Compare
OGPoyraz
commented
May 5, 2023
vinistevam
force-pushed
the
feat/783-trigger-modal-using-approval-controller-on-qr-signing
branch
from
June 14, 2023 05:28
9616ef7
to
cb32458
Compare
vinistevam
force-pushed
the
feat/783-trigger-modal-using-approval-controller-on-qr-signing
branch
2 times, most recently
from
June 15, 2023 15:16
259698f
to
0b8a205
Compare
vinistevam
force-pushed
the
feat/783-trigger-modal-using-approval-controller-on-qr-signing
branch
from
June 16, 2023 08:00
0b8a205
to
bda93b9
Compare
…ller-on-qr-signing
…ller-on-qr-signing
OGPoyraz
commented
Jun 19, 2023
vinistevam
previously approved these changes
Jun 19, 2023
…ller-on-qr-signing
…ller-on-qr-signing
…ller-on-qr-signing
vinistevam
approved these changes
Jun 23, 2023
matthewwalsh0
approved these changes
Jun 23, 2023
Kudos, SonarCloud Quality Gate passed! |
OGPoyraz
deleted the
feat/783-trigger-modal-using-approval-controller-on-qr-signing
branch
June 23, 2023 09:38
metamaskbot
added
the
release-7.3.0
Issue or pull request that will be included in release 7.3.0
label
Jun 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xx
label to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-review
label when work is completedneeds-qa
label when dev review is completedQA Passed
label when QA has signed offDescription
The main goal of this PR is to trigger the
qrsigning
modal using the approval controller aligning the approach across the existing modals.Screenshots/Recordings
1_Pair_unpair_keystone_MetaMask.mp4
2-create-token-keystone-metamask_qLMEcbFz.mp4
3_Transfer_tokens_keystone_MetaMask.mp4
4_Transfer_token_without_gas_keystone_MetaMask.mp4
5_Sign_personal_typed_keystone_MetaMask.mp4
6_Forget_this_device_keystone_MetaMask.mp4
Second round of tests:
keystone_test_1.mp4
keystone_test_2.mp4
keystone_test_3.mp4
Issue
resolves: https://github.com/MetaMask/mobile-planning/issues/783
Checklist