feat: trigger qrsigning modal using approval controller (#6212) #6720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: trigger qrsigning modal using approval controller * fix: use approval request to control QR modal * remove QRState usage * use approval request to control QR modal for tx * fix lint * add early return on qr signing modal --------- Co-authored-by: Vinicius Stevam <[email protected]> Co-authored-by: Vinicius Stevam <[email protected]>
sethkfman
added
the
needs-dev-review
gauthierpetetin
added
in-progress
ready-for-dev
needs-dev-review
gantunesr
approved these changes
Jun 28, 2023
…0d730279e5fc516fdf23f
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
plasmacorral
added
needs-qa
|
Kudos, SonarCloud Quality Gate passed! |
plasmacorral
added
QA in Progress
|
Was unable to build iOS, but did confirm with a QA build using Samsung A515f running Android 11 that QR confirmations now appear. Spot checked: From the test dapp, all with no issues. |
plasmacorral
added
QA Passed
plasmacorral
deleted the
fix/cherry-pick-96473d39538b16ab7370d730279e5fc516fdf23f
branch
plasmacorral
added
the
release-7.2.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Cherry pick PR from main to fix HW QR scanner issue.
Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your change
Issue
Progresses #RC blocker
Checklist