Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Custom Nonce Issues #6707

Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: Custom Nonce Issues #6707

merged 1 commit into from
Jun 30, 2023

Conversation

segun
Copy link
Contributor

@segun segun commented Jun 27, 2023

Whenever we are performing a tx from a dapp, we get the error undefined is not an object (evaluating transactionMeta.transaction) and cannot send the transaction if we have Customize Tx Nonce setting enabled and then we disabled it.

Screenshots

undefined-not-object-transaction-meta.mp4

To Reproduce
Steps to reproduce the behavior

  1. Enable Customize tx Nonce from settings
  2. Go to test-dapp
  3. Connect MM
  4. Deploy an ERC20 token
  5. Click Send token
  6. Confirm
  7. Now change disable Customize tx nonce
  8. Click again Send token
  9. Confirm
  10. See error

Expected behavior
No error should appear, tx should succeed.

Issue

Fixes #6604

Checklist

  • [x ] There is a related GitHub issue
  • Tests are included if applicable
  • [x ] Any added code is fully documented

@segun segun requested a review from a team as a code owner June 27, 2023 04:47
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@segun segun self-assigned this Jun 27, 2023
@segun segun added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Jun 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

blackdevelopa
blackdevelopa previously approved these changes Jun 27, 2023
View reviewed changes
@blackdevelopa
Copy link
Contributor

Can you change the base of this PR to the release PR since it's a release blocker?

@segun segun changed the base branch from main to release/7.2.0 June 28, 2023 16:08
@segun segun changed the base branch from release/7.2.0 to main June 28, 2023 16:12
@segun segun changed the base branch from main to release/7.2.0 June 28, 2023 16:17
@segun segun requested a review from blackdevelopa June 28, 2023 16:20
@seaona
Copy link
Contributor

seaona commented Jun 29, 2023

From QA looks good, I can see the issue fixed 💯

custom-nonce-fix.webm

@seaona seaona added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 29, 2023
@segun segun merged commit c91ec26 into release/7.2.0 Jun 30, 2023
@segun segun deleted the fix-custom-nonce-error branch June 30, 2023 10:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@digiwand digiwand digiwand approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Assignees

@segun segun

Labels
QA Passed A successful QA run through has been done team-confirmations-secure-ux-PR PR from the confirmations team
Projects
None yet
Milestone
No milestone
5 participants
@segun @blackdevelopa @seaona @matthewwalsh0 @digiwand