Bring feature/ufs_dom up to date with develop#918
Merged
climbfuji merged 24 commits intofeature/ufs_domfrom Jul 17, 2023
Merged
Bring feature/ufs_dom up to date with develop#918climbfuji merged 24 commits intofeature/ufs_domfrom
climbfuji merged 24 commits intofeature/ufs_domfrom
Conversation
* set to min/max instead of 0 * ... * vanilla vert conv * tidy sign * removed jac_mask * tanh filt * updated yamls and test refs * merge develop and update answers after the develop history MESS i created * code tidy/removed vanilla --------- Co-authored-by: Travis Sluka <tsluka@ucar.edu>
Co-authored-by: Travis Sluka <tsluka@ucar.edu>
* add vader to build, but dont use it * add State::fromFieldSet * variablechange "uses" vader
* added the ensmeanandvariance app * ... --------- Co-authored-by: Travis Sluka <tsluka@ucar.edu>
* skip sqrt, saving optional * forgot test yaml * Update test/testinput/varchange_bkgerrsoca_stddev.yml Co-authored-by: Travis Sluka <tsluka@ucar.edu> --------- Co-authored-by: Travis Sluka <tsluka@ucar.edu>
* use oops interpolation * to_fieldset_ad * forgot some halo masks * fix horizfilt * fix some test answers * letkf workaround for missing val bug * work around for getvalues test * change obs input to have 1 guaranteed land point
Co-authored-by: Yannick Trémolet <30638944+ytremolet@users.noreply.github.com>
* Merge B matrix-related applications * Trigger tests --------- Co-authored-by: Benjamin Menetrier <benjamin.menetrier@irit.fr> Co-authored-by: Travis Sluka <tsluka@ucar.edu>
* add ModelData * fix coding norms
* a fix dvdz * Updating test references --------- Co-authored-by: Hyun-Chul.Lee <Hyun-Chul.Lee@noaa.gov>
cmgas
changed the title
3 tasks
climbfuji
requested changes
Jul 14, 2023
Contributor
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
I am getting a failure compiling the NG-GODAS configuration. Maybe @travissluka has an idea and a quick fix? I'll keep looking in the meanwhile.
-- Configuring done
CMake Error at /Users/heinzell/prod/spack-stack-1.4.1/envs/unified-env/install/apple-clang/13.1.6/ecbuild-3.7.2-ksok6t6/share/ecbuild/cmake/ecbuild_add_executable.cmake:209 (add_executable):
Cannot find source file:
Dirac.cc
Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
.hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
Call Stack (most recent call first):
soca/src/mains/CMakeLists.txt:1 (ecbuild_add_executable)
CMake Error at /Users/heinzell/prod/spack-stack-1.4.1/envs/unified-env/install/apple-clang/13.1.6/ecbuild-3.7.2-ksok6t6/share/ecbuild/cmake/ecbuild_add_executable.cmake:209 (add_executable):
No SOURCES given to target: soca_dirac.x
Call Stack (most recent call first):
soca/src/mains/CMakeLists.txt:1 (ecbuild_add_executable)
CMake Generate step failed. Build files cannot be regenerated correctly.
Contributor
|
Should be an easy fix ... stay tuned |
…d for fv3-jedi prevent the following error:
-- Configuring done
CMake Error in soca/src/soca/CMakeLists.txt:
Target "soca" INTERFACE_LINK_DIRECTORIES property contains path:
"/Users/heinzell/work/ufs-bundle/20230714/ufs-bundle-use-jedi-develop/soca/src/soca/."
which is prefixed in the source directory.
-- Generating done
CMake Generate step failed. Build files cannot be regenerated correctly.
Contributor
|
Next error is: This can be "fixed" by using the compiler wrappers in the ecbuild command ( |
… libraries due to ESMF bug
Contributor
|
This now works. I remember the bug fix I added to fv3-jedi to fix that problem. It's a bug introduced by ESMF. See commit 3b2f451. |
climbfuji
approved these changes
Jul 14, 2023
Contributor
|
@travissluka Please review and merge straight into feature/ufs_dom if ok. Thanks! |
Contributor
|
@travissluka I'll merge this, since it's only going into my branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings feature/ufs_dom up to date with develop