Merged
Conversation
svahl991
approved these changes
May 23, 2023
| VariableChange::VariableChange(const Parameters_ & params, | ||
| const Geometry & geometry) { | ||
| // setup vader | ||
| vader_.reset(new vader::Vader(params.vader)); |
Contributor
There was a problem hiding this comment.
You might consider passing Vader a defined cookbook when you construct it, maybe just including a single recipe for now. (I haven't tested Vader with an empty cookbook.) That way you control it. Otherwise Vader will use its default cookbook, which gets updated from time to time. But since Vader doesn't currently have any recipes (I don't think) for variables you're producing, it probably doesn't matter much either way right now.
Contributor
Author
There was a problem hiding this comment.
@ svahl991 Thanks I thought about that, but I figured would take my chances for now since there are no relevant recipes that could break anything for me. I'll add a proper cookbook when I (soonish?) work on getting some marine var changes into vader.
climbfuji
added a commit
that referenced
this pull request
Jul 17, 2023
* Use SABER blocks chaining for training (#852) * Adapt to name changes in ufo (#867) * Use VertInterp instead of MarineVertInterp (#874) * remove linear var change from ensevariance ctest (#881) * Bugfixes for BUMP (#869) * A few fixes to the Model to Analysis variable change (#847) * Remove discontinuities in the balance op (#885) * set to min/max instead of 0 * ... * vanilla vert conv * tidy sign * removed jac_mask * tanh filt * updated yamls and test refs * merge develop and update answers after the develop history MESS i created * code tidy/removed vanilla --------- Co-authored-by: Travis Sluka <tsluka@ucar.edu> * default plots (#888) Co-authored-by: Travis Sluka <tsluka@ucar.edu> * add VADER to SOCA (#887) * add vader to build, but dont use it * add State::fromFieldSet * variablechange "uses" vader * switched to ens. templ. (#894) * Implementation of EnsMeanAndVariance (#892) * added the ensmeanandvariance app * ... --------- Co-authored-by: Travis Sluka <tsluka@ucar.edu> * Read the std. dev. instead of the variance (#896) * skip sqrt, saving optional * forgot test yaml * Update test/testinput/varchange_bkgerrsoca_stddev.yml Co-authored-by: Travis Sluka <tsluka@ucar.edu> --------- Co-authored-by: Travis Sluka <tsluka@ucar.edu> * Use the generic oops interpolator (#898) * use oops interpolation * to_fieldset_ad * forgot some halo masks * fix horizfilt * fix some test answers * letkf workaround for missing val bug * work around for getvalues test * change obs input to have 1 guaranteed land point * Update version (#899) * remove ewok repo (#889) Co-authored-by: Yannick Trémolet <30638944+ytremolet@users.noreply.github.com> * Merge B matrix-related applications (#890) * Merge B matrix-related applications * Trigger tests --------- Co-authored-by: Benjamin Menetrier <benjamin.menetrier@irit.fr> Co-authored-by: Travis Sluka <tsluka@ucar.edu> * update for VADER PR#586 (#902) * add ModelData * fix coding norms * Update CMakeLists.txt * Fix vertical gradient (#914) * a fix dvdz * Updating test references --------- Co-authored-by: Hyun-Chul.Lee <Hyun-Chul.Lee@noaa.gov> * libs in soca * Commend out dirac.x test and disable ecbuild_install_project as we did for fv3-jedi prevent the following error: -- Configuring done CMake Error in soca/src/soca/CMakeLists.txt: Target "soca" INTERFACE_LINK_DIRECTORIES property contains path: "/Users/heinzell/work/ufs-bundle/20230714/ufs-bundle-use-jedi-develop/soca/src/soca/." which is prefixed in the source directory. -- Generating done CMake Generate step failed. Build files cannot be regenerated correctly. * Apply same bug fix as for fv3-jedi to fix missing linker path for MPI libraries due to ESMF bug --------- Co-authored-by: Benjamin Menetrier <benjamin.menetrier@irit.fr> Co-authored-by: Wojciech Śmigaj <w.smigaj@gmail.com> Co-authored-by: Travis Sluka <tsluka@ucar.edu> Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov> Co-authored-by: Yannick Trémolet <30638944+ytremolet@users.noreply.github.com> Co-authored-by: Benjamin Menetrier <30638301+benjaminmenetrier@users.noreply.github.com> Co-authored-by: Kriti Bhargava <kritib@ucar.edu> Co-authored-by: Hyun-Chul.Lee <Hyun-Chul.Lee@noaa.gov> Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds VADER to SOCA, and is "used" in the nonlinear variable change, (We don't have any recipes that do anything we would want, so it currently does nothing), but compiling with VADER is now part of the TravisCI.
I had to add the
soca::State::fromFieldSet()method for this.testing
The changes do nothing. No change in ctests answers. We'll actually start making use of VADER at a later date (soonish?)