Skip to content

Use develop branches for repositories in ufs bundle#30

Merged
climbfuji merged 22 commits intodevelopfrom
feature/use_develop
Jul 17, 2023
Merged

Use develop branches for repositories in ufs bundle#30
climbfuji merged 22 commits intodevelopfrom
feature/use_develop

Conversation

@cmgas
Copy link
Contributor

@cmgas cmgas commented Jun 14, 2023

@cmgas cmgas requested a review from climbfuji July 3, 2023 22:22
@shlyaeva shlyaeva requested a review from fcvdb July 10, 2023 14:55
@climbfuji climbfuji requested a review from shlyaeva July 14, 2023 17:16
Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shlyaeva @fcvdb I just pushed an update to the top-level README.md to this branch, commit 9e4a576.

Can you please review the combined changes and my additional suggestions for change as part of this review? I am currently testing the PR on my macOS.

Copy link
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all works for me, I can compile UFS_APPs ATM, ATMAERO, NG-GODAS, S2S. The ATM ctests (warmstart) pass, the coldstart tests fail as expected.

Copy link
Collaborator

@shlyaeva shlyaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and as @climbfuji suggested, would be great to have CI on this now that it uses develop for most branches in the bundle (otherwise it may be hard to find which changes will be breaking it eventually).

module load jedi-ufs-env/skylab-dev
module load jedi-ufs-env/unified-dev
```
Further, for testing of the newest `fms@2023.02-beta1` tag, verify if the platform you are on has this version available and if yes, run
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this include the change that soca needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@travissluka tested this already (he said)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 you rock!
we'll test with fv3-jedi too, unless @travissluka you already tested with both soca and fv3-jedi?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the tag of fms contains the changes that SOCA needs, but the ufs-weather-model, fv3-jedi-linearmodel and fv3-jedi don't work with that tag ye. See ufs-community/ccpp-physics#90 and https://github.com/JCSDA-internal/fv3-jedi-linearmodel/issues/18 for examples. Also, see NOAA-GFDL/FMS#1284 for bugs in the build system of that tag.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, so testing https://github.com/JCSDA-internal/fv3-bundle/pull/103 (with updates to jcsda repos) isn't expected to work?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least at the moment, not. Let's see how far we get this week.

@climbfuji climbfuji merged commit 6e25126 into develop Jul 17, 2023
@climbfuji climbfuji deleted the feature/use_develop branch July 17, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update JEDI code in ufs-bundle to run with crtm@2.4.1 (or v3)

3 participants