Skip to content

Bugfixes for BUMP#869

Merged
travissluka merged 10 commits intodevelopfrom
bugfix/minimal_amplitude
May 4, 2023
Merged

Bugfixes for BUMP#869
travissluka merged 10 commits intodevelopfrom
bugfix/minimal_amplitude

Conversation

@benjaminmenetrier
Copy link
Contributor

@benjaminmenetrier benjaminmenetrier marked this pull request as ready for review April 26, 2023 08:50
Benjamin Menetrier added 2 commits April 28, 2023 16:11
@shlyaeva shlyaeva requested a review from travissluka May 2, 2023 14:22
@shlyaeva
Copy link
Collaborator

shlyaeva commented May 2, 2023

@travissluka the plan is to merge this series of PRs on Thursday. I think the failing test is the same as on develop.

@travissluka travissluka added coordinate merge Ready for merge but needs to be coordinated with other repos SOCA Sea-ice, Ocean, and Coupled Assimilation labels May 4, 2023
@shlyaeva
Copy link
Collaborator

shlyaeva commented May 4, 2023

saber PR was merged, this PR is ready for merge now

@travissluka travissluka merged commit 8fd638d into develop May 4, 2023
@travissluka travissluka deleted the bugfix/minimal_amplitude branch May 4, 2023 15:02
travissluka pushed a commit that referenced this pull request May 12, 2023
climbfuji added a commit that referenced this pull request Jul 17, 2023
* Use SABER blocks chaining for training (#852)

* Adapt to name changes in ufo (#867)

* Use VertInterp instead of MarineVertInterp (#874)

* remove linear var change from ensevariance ctest (#881)

* Bugfixes for BUMP (#869)

* A few fixes to the Model to Analysis variable change (#847)

* Remove discontinuities in the balance op  (#885)

* set to min/max instead of 0

* ...

* vanilla vert conv

* tidy sign

* removed jac_mask

* tanh filt

* updated yamls and test refs

* merge develop and update answers after the develop history MESS i created

* code tidy/removed vanilla

---------

Co-authored-by: Travis Sluka <tsluka@ucar.edu>

* default plots (#888)

Co-authored-by: Travis Sluka <tsluka@ucar.edu>

* add VADER to SOCA (#887)

* add vader to build, but dont use it

* add State::fromFieldSet

* variablechange "uses" vader

* switched to ens. templ. (#894)

* Implementation of EnsMeanAndVariance (#892)

* added the ensmeanandvariance app

* ...

---------

Co-authored-by: Travis Sluka <tsluka@ucar.edu>

* Read the std. dev. instead of the variance (#896)

* skip sqrt, saving optional

* forgot test yaml

* Update test/testinput/varchange_bkgerrsoca_stddev.yml

Co-authored-by: Travis Sluka <tsluka@ucar.edu>

---------

Co-authored-by: Travis Sluka <tsluka@ucar.edu>

* Use the generic oops interpolator (#898)

* use oops interpolation

* to_fieldset_ad

* forgot some halo masks

* fix horizfilt

* fix some test answers

* letkf workaround for missing val bug

* work around for getvalues test

* change obs input to have 1 guaranteed land point

* Update version (#899)

* remove ewok repo (#889)

Co-authored-by: Yannick Trémolet <30638944+ytremolet@users.noreply.github.com>

* Merge B matrix-related applications (#890)

* Merge B matrix-related applications

* Trigger tests

---------

Co-authored-by: Benjamin Menetrier <benjamin.menetrier@irit.fr>
Co-authored-by: Travis Sluka <tsluka@ucar.edu>

* update for VADER PR#586 (#902)

* add ModelData

* fix coding norms

* Update CMakeLists.txt

* Fix vertical gradient (#914)

* a fix dvdz

* Updating test references

---------

Co-authored-by: Hyun-Chul.Lee <Hyun-Chul.Lee@noaa.gov>

* libs in soca

* Commend out dirac.x test and disable ecbuild_install_project as we did for fv3-jedi prevent the following error:

-- Configuring done
CMake Error in soca/src/soca/CMakeLists.txt:
  Target "soca" INTERFACE_LINK_DIRECTORIES property contains path:

    "/Users/heinzell/work/ufs-bundle/20230714/ufs-bundle-use-jedi-develop/soca/src/soca/."

  which is prefixed in the source directory.

-- Generating done
CMake Generate step failed.  Build files cannot be regenerated correctly.

* Apply same bug fix as for fv3-jedi to fix missing linker path for MPI libraries due to ESMF bug

---------

Co-authored-by: Benjamin Menetrier <benjamin.menetrier@irit.fr>
Co-authored-by: Wojciech Śmigaj <w.smigaj@gmail.com>
Co-authored-by: Travis Sluka <tsluka@ucar.edu>
Co-authored-by: Guillaume Vernieres <guillaume.vernieres@noaa.gov>
Co-authored-by: Yannick Trémolet <30638944+ytremolet@users.noreply.github.com>
Co-authored-by: Benjamin Menetrier <30638301+benjaminmenetrier@users.noreply.github.com>
Co-authored-by: Kriti Bhargava <kritib@ucar.edu>
Co-authored-by: Hyun-Chul.Lee <Hyun-Chul.Lee@noaa.gov>
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coordinate merge Ready for merge but needs to be coordinated with other repos SOCA Sea-ice, Ocean, and Coupled Assimilation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants