Skip to content

Bugfixes for BUMP #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
travissluka merged 10 commits into from
May 4, 2023
Merged

Bugfixes for BUMP #869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bc6ae2d
Update yamls
Mar 8, 2023
d7697fd
Merge branch 'develop' into feature/saber_blocks_for_training
Apr 13, 2023
a66cd7d
Update source and yamls
Apr 13, 2023
848ba5c
Merge branch 'develop' into feature/saber_blocks_for_training
travissluka Apr 18, 2023
5d1a7ad
Merge pull request #852 from JCSDA-internal/feature/saber_blocks_for_…
travissluka Apr 19, 2023
b79b11a
Fix ref
Apr 24, 2023
d483c72
Merge branch 'develop' into bugfix/minimal_amplitude
benjaminmenetrier Apr 26, 2023
c0ab584
Update yamls
Apr 28, 2023
90958f0
Trigger tests
Apr 28, 2023
9510d30
Merge branch 'develop' into bugfix/minimal_amplitude
shlyaeva May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions test/testinput/3dvarbump.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ cost function:
read:
io:
data directory: data_generated/parameters_bump_cor_nicas
files prefix: bump
drivers:
multivariate strategy: univariate
read local nicas: true
Expand All @@ -40,13 +41,9 @@ cost function:
- tocn
- uocn
- vocn
io:
files prefix: bump3d
- model:
variables:
- ssh
io:
files prefix: bump2d

linear variable change:
input variables: *soca_vars
Expand Down
5 changes: 1 addition & 4 deletions test/testinput/dirac_soca_cor_nicas_scales.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ background error:
read:
io:
data directory: data_generated/parameters_bump_cor_nicas_scales
files prefix: bump
drivers:
multivariate strategy: univariate
read local nicas: true
Expand All @@ -26,15 +27,11 @@ background error:
variables:
- socn
- tocn
io:
files prefix: bump3d
- model:
variables:
- ssh
- cicen
- hicen
io:
files prefix: bump2d

dirac:
ixdir: [1, 17, 41, 31, 51, 63, 81, 14, 16, 43]
Expand Down
5 changes: 1 addition & 4 deletions test/testinput/parameters_bump_cor_nicas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ background error:
calibration:
io:
data directory: data_generated/parameters_bump_cor_nicas
files prefix: bump
drivers:
multivariate strategy: univariate
compute nicas: true
Expand Down Expand Up @@ -51,13 +52,9 @@ background error:
- tocn
- uocn
- vocn
io:
files prefix: bump3d
- model:
variables:
- ssh
io:
files prefix: bump2d
output model files:
- parameter: cor_rh
file:
Expand Down
5 changes: 1 addition & 4 deletions test/testinput/parameters_bump_cor_nicas_scales.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ background error:
calibration:
io:
data directory: data_generated/parameters_bump_cor_nicas_scales
files prefix: bump
drivers:
multivariate strategy: univariate
compute nicas: true
Expand All @@ -33,15 +34,11 @@ background error:
- tocn
- uocn
- vocn
io:
files prefix: bump3d
- model:
variables:
- ssh
- cicen
- hicen
io:
files prefix: bump2d
input model files:
- parameter: rh
file:
Expand Down
6 changes: 3 additions & 3 deletions test/testref/dirac_soca_cor_nicas_scales.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ Input Dirac increment:
hicen min=0.0000000000000000 max=1.0000000000000000 mean=0.0006086427267194
Covariance(SABER) * Increment:
Valid time: 2018-04-15T00:00:00Z
socn min=0.0000000000000000 max=1.0000000000000002 mean=0.0293635005803741
tocn min=0.0000000000000000 max=1.0530523404044794 mean=0.3769034423956199
socn min=0.0000000000000000 max=1.0000000000000002 mean=0.0340141737787489
tocn min=0.0000000000000000 max=1.0048129708997011 mean=0.3536185118881098
ssh min=0.0000000000000000 max=0.0000000000000000 mean=0.0000000000000000
hocn min=0.0000000000000000 max=0.0000000000000000 mean=0.0000000000000000
cicen min=0.0000000000000000 max=0.0000000000000000 mean=0.0000000000000000
hicen min=0.0000000000000000 max=1.0000000000000002 mean=0.2640285296287257
hicen min=0.0000000000000000 max=0.9999999999999998 mean=0.2640285296287256