Merged
Conversation
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
… fails on trunk. (#2503)
…tor. (#2487) Contributed by Kuhu Shukla and Ahmed Hussein
…mptionPolicyMockFramework. Contributed by Szilard Nemeth (snemeth)
…ontributed by Daryn Sharp and Ahmed Hussein
…2508). Contributed by Daryn Sharp and Ahmed Hussein
…n each iteration (#2483). Contributed by Leon Gao.
DETAILS:
The previous commit for HADOOP-17397 was not the correct fix. DelegationSASGenerator.getDelegationSAS
should return sp=p for the set-permission and set-acl operations. The tests have also been updated as
follows:
1. When saoid and suoid are not specified, skoid must have an RBAC role assignment which grants
Microsoft.Storage/storageAccounts/blobServices/containers/blobs/modifyPermissions/action and sp=p
to set permissions or set ACL.
2. When saoid or suiod is specified, same as 1) but furthermore the saoid or suoid must be an owner of
the file or directory in order for the operation to succeed.
3. When saoid or suiod is specified, the ownership check is bypassed by also including 'o' (ownership)
in the SAS permission (for example, sp=op). Note that 'o' grants the saoid or suoid the ability to
change the file or directory owner to themself, and they can also change the owning group. Generally
speaking, if a trusted authorizer would like to give a user the ability to change the permissions or
ACL, then that user should be the file or directory owner.
TEST RESULTS:
namespace.enabled=true
auth.type=SharedKey
-------------------
$mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify
Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
Tests run: 462, Failures: 0, Errors: 0, Skipped: 24
Tests run: 208, Failures: 0, Errors: 0, Skipped: 24
namespace.enabled=true
auth.type=OAuth
-------------------
$mvn -T 1C -Dparallel-tests=abfs -Dscale -DtestsThreadCount=8 clean verify
Tests run: 90, Failures: 0, Errors: 0, Skipped: 0
Tests run: 462, Failures: 0, Errors: 0, Skipped: 70
Tests run: 208, Failures: 0, Errors: 0, Skipped: 141
Reviewed-by: Adam Antal <adamantal@apache.org> Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
…ion class (#2486). Contributed by Daryn Sharp and Ahmed Hussein
…ction leading to CLOSE_WAIT cnxns. Contributed by Attila Magyar. Signed-off-by: Wei-Chiu Chuang <weichiu@apache.org>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org> Reviewed-by: Jim Brennan <jbrennan@apache.org>
…error. Contributed by HuangTao.
…c}. Contributed by Fengnan Li and CR Hota.
…storage locations. Contributed by Yang Yun.
…Contributed by Ryan Wu.
…buted by angerszhu.
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Signed-off-by: Akira Ajisaka <ajisaka@apache.org>
#2494) Contributed by Qi Zhu.
…andler (#2527). Contributed by Wanqiang Ji
…d Hussein and Kihwal Lee
… not 0.0.0.0. Contributed by Eric Badger
…h the DNs never finalize. Contributed by Stephen O'Donnell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sync