HADOOP-17399. lz4 sources missing for native Visual Studio project#2498
Merged
sunchao merged 1 commit intoapache:trunkfrom Nov 30, 2020
Merged
HADOOP-17399. lz4 sources missing for native Visual Studio project#2498sunchao merged 1 commit intoapache:trunkfrom
sunchao merged 1 commit intoapache:trunkfrom
Conversation
* The sources for lz4 do not exist for native vcxproj for Visual Studio on the Windows platform. Hence, removing the corresponding source references.
|
💔 -1 overall
This message was automatically generated. |
Member
Author
|
This PR only changes the build related code, which can't be tested. |
sunchao
approved these changes
Nov 29, 2020
Member
sunchao
left a comment
There was a problem hiding this comment.
LTGM - thanks @GauthamBanasandra . cc @viirya
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vcxproj for Visual Studio on the Windows
platform. Hence, removing the corresponding
source references.