HDFS-15712. Upgrade googletest to 1.10.0 #2523

GauthamBanasandra · 2020-12-05T16:41:38Z

Upgrading the googletest library to
1.10.0.
Removing the older, checked-in gmock
from third_party.

* Upgrading the googletest library to 1.10.0. * Removing the older, checked-in gmock from third_party.

hadoop-yetus · 2020-12-05T18:34:15Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	26m 27s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 39s		trunk passed
+1 💚	compile	1m 57s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	2m 0s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	mvnsite	0m 27s		trunk passed
+1 💚	shadedclient	52m 25s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 23s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 22s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	1m 55s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	cc	1m 55s		the patch passed
+1 💚	golang	1m 55s		the patch passed
+1 💚	javac	1m 55s		the patch passed
+1 💚	compile	1m 56s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	cc	1m 56s		the patch passed
+1 💚	golang	1m 56s		the patch passed
+1 💚	javac	1m 56s		the patch passed
+1 💚	mvnsite	0m 18s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	14m 57s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 19s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Other Tests _
+1 💚	unit	7m 30s		hadoop-hdfs-native-client in the patch passed.
-1 ❌	asflicense	0m 32s	/patch-asflicense-problems.txt	The patch generated 1 ASF License warnings.
		111m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/1/artifact/out/Dockerfile
GITHUB PR	#2523
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient cc golang
uname	Linux 51efb6e22c7f 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7dda804`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/1/testReport/
Max. process+thread count	536 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/1/console
versions	git=2.17.1 maven=3.6.0
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

* Added Apache license for CMakeLists-gtest.txt.in.

hadoop-yetus · 2020-12-06T04:54:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 57s		trunk passed
+1 💚	compile	1m 58s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	2m 1s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	mvnsite	0m 28s		trunk passed
+1 💚	shadedclient	53m 2s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 24s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 22s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	1m 54s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	cc	1m 54s		the patch passed
+1 💚	golang	1m 54s		the patch passed
+1 💚	javac	1m 54s		the patch passed
+1 💚	compile	1m 55s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	cc	1m 55s		the patch passed
+1 💚	golang	1m 55s		the patch passed
+1 💚	javac	1m 55s		the patch passed
+1 💚	mvnsite	0m 17s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	15m 8s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 18s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Other Tests _
+1 💚	unit	7m 25s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		86m 21s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/2/artifact/out/Dockerfile
GITHUB PR	#2523
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient cc golang
uname	Linux 6987c0fa6415 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7dda804`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/2/testReport/
Max. process+thread count	536 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/2/console
versions	git=2.17.1 maven=3.6.0
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-12-06T04:58:59Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 46s		trunk passed
+1 💚	compile	1m 58s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	2m 2s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	mvnsite	0m 28s		trunk passed
+1 💚	shadedclient	52m 30s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 23s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	1m 55s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	cc	1m 55s		the patch passed
+1 💚	golang	1m 55s		the patch passed
+1 💚	javac	1m 55s		the patch passed
+1 💚	compile	1m 57s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	cc	1m 57s		the patch passed
+1 💚	golang	1m 57s		the patch passed
+1 💚	javac	1m 57s		the patch passed
+1 💚	mvnsite	0m 16s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	14m 59s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 18s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Other Tests _
+1 💚	unit	7m 27s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		85m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/3/artifact/out/Dockerfile
GITHUB PR	#2523
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient cc golang
uname	Linux a49497828d0e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7dda804`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/3/testReport/
Max. process+thread count	538 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/3/console
versions	git=2.17.1 maven=3.6.0
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

GauthamBanasandra · 2020-12-06T05:00:04Z

My PR doesn't modify any functionality, rather, it just upgrades the googletest library. Thus, it doesn't require any modification or addition of any unit tests.

GauthamBanasandra · 2020-12-06T05:00:26Z

Hi @aajisaka, could you please review my PR?

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists-gtest.txt.in

* Upgrading the CMake minimum required version to 3.1 as that's what's Hadoop's using. Co-authored-by: Akira Ajisaka <[email protected]>

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists-gtest.txt.in

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt

* Removing the redundant headers for license as they've already been attributed in ./licenses/LICENSE-gtest.txt and ./licenses-binary/LICENSE-gtest.txt.

* Removing CMake 2.8 related workarounds as Hadoop currently uses CMake 3.1.

aajisaka

+1 pending Jenkins. Thank you @GauthamBanasandra

GauthamBanasandra · 2020-12-07T08:28:38Z

Thanks @aajisaka

hadoop-yetus · 2020-12-07T08:54:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
-1 ❌	mvninstall	14m 44s	/branch-mvninstall-root.txt	root in trunk failed.
-1 ❌	compile	1m 54s	/branch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt	hadoop-hdfs-native-client in trunk failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌	compile	0m 26s	/branch-compile-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt	hadoop-hdfs-native-client in trunk failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌	mvnsite	0m 10s	/branch-mvnsite-hadoop-hdfs-project_hadoop-hdfs-native-client.txt	hadoop-hdfs-native-client in trunk failed.
+1 💚	shadedclient	33m 39s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 24s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 19s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 17s		the patch passed
+1 💚	compile	1m 55s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
-1 ❌	cc	1m 55s	/diff-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt	hadoop-hdfs-project_hadoop-hdfs-native-client-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 10 new + 8 unchanged - 0 fixed = 18 total (was 8)
+1 💚	golang	1m 55s		the patch passed
+1 💚	javac	1m 55s		the patch passed
+1 💚	compile	1m 56s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
-1 ❌	cc	1m 56s	/diff-compile-cc-hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt	hadoop-hdfs-project_hadoop-hdfs-native-client-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 generated 18 new + 0 unchanged - 0 fixed = 18 total (was 0)
+1 💚	golang	1m 56s		the patch passed
+1 💚	javac	1m 56s		the patch passed
+1 💚	mvnsite	0m 21s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	14m 52s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 18s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 18s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Other Tests _
+1 💚	unit	7m 26s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		66m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/4/artifact/out/Dockerfile
GITHUB PR	#2523
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient cc golang
uname	Linux d1d49dc9e756 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7dda804`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/4/testReport/
Max. process+thread count	659 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/4/console
versions	git=2.17.1 maven=3.6.0
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

GauthamBanasandra · 2020-12-07T09:09:57Z

My changes are only in HDFS Native client and it seems to have compiled successfully in the above run -

mvn install

[INFO] Apache Hadoop HDFS Native Client ................... SUCCESS [  0.463 s]

The other failures in the above run seem to be due to resource unavailability while compiling an unrelated component -
compile

[WARNING] c++: error: vfork: Resource temporarily unavailable
[WARNING] make[2]: *** [main/native/libhdfspp/lib/proto/CMakeFiles/proto_obj.dir/ClientNamenodeProtocol.pb.cc.o] Error 1

mvnsite

Mon Dec  7 08:06:34 UTC 2020
cd /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2523/src/hadoop-hdfs-project/hadoop-hdfs-native-client
/usr/bin/mvn --batch-mode -Dmaven.repo.local=/home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-2523/yetus-m2/hadoop-trunk-patch-1 -Ptest-patch clean site site:stage
/usr/bin/mvn: 45: /usr/bin/mvn: Cannot fork

hadoop-yetus · 2020-12-07T09:24:53Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 6s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 12s		trunk passed
+1 💚	compile	2m 0s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	2m 6s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	mvnsite	0m 21s		trunk passed
+1 💚	shadedclient	57m 1s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 19s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 18s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 15s		the patch passed
+1 💚	compile	1m 59s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	cc	1m 59s		the patch passed
+1 💚	golang	1m 59s		the patch passed
+1 💚	javac	1m 59s		the patch passed
+1 💚	compile	2m 0s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	cc	2m 0s		the patch passed
+1 💚	golang	2m 0s		the patch passed
+1 💚	javac	2m 0s		the patch passed
+1 💚	mvnsite	0m 15s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	16m 40s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 15s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 15s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
			_ Other Tests _
+1 💚	unit	7m 21s		hadoop-hdfs-native-client in the patch passed.
+1 💚	asflicense	0m 30s		The patch does not generate ASF License warnings.
		91m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/5/artifact/out/Dockerfile
GITHUB PR	#2523
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient cc golang
uname	Linux 7c759b5fb45c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7dda804`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/5/testReport/
Max. process+thread count	600 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-native-client U: hadoop-hdfs-project/hadoop-hdfs-native-client
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2523/5/console
versions	git=2.17.1 maven=3.6.0
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka · 2020-12-07T11:04:08Z

I'll commit this tomorrow if there are no objections.

HDFS-15712. Upgrade googletest to 1.10.0

9efbc0e

* Upgrading the googletest library to 1.10.0. * Removing the older, checked-in gmock from third_party.

Add Apache license

5f701bc

* Added Apache license for CMakeLists-gtest.txt.in.

GauthamBanasandra force-pushed the rem-gmock branch from 0258e49 to 5f701bc Compare December 6, 2020 03:32

aajisaka reviewed Dec 7, 2020

View reviewed changes

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt Outdated Show resolved Hide resolved

aajisaka reviewed Dec 7, 2020

View reviewed changes

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists-gtest.txt.in Outdated Show resolved Hide resolved

Upgrade CMake version for gtest

99e6e7d

* Upgrading the CMake minimum required version to 3.1 as that's what's Hadoop's using. Co-authored-by: Akira Ajisaka <[email protected]>

aajisaka reviewed Dec 7, 2020

View reviewed changes

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists-gtest.txt.in Outdated Show resolved Hide resolved

aajisaka reviewed Dec 7, 2020

View reviewed changes

hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt Outdated Show resolved Hide resolved

GauthamBanasandra added 2 commits December 7, 2020 13:18

Remove redundant license headers

73d70b6

* Removing the redundant headers for license as they've already been attributed in ./licenses/LICENSE-gtest.txt and ./licenses-binary/LICENSE-gtest.txt.

Do not handle CMake 2.8 limitations

3b45e0a

* Removing CMake 2.8 related workarounds as Hadoop currently uses CMake 3.1.

GauthamBanasandra requested a review from aajisaka December 7, 2020 07:55

aajisaka approved these changes Dec 7, 2020

View reviewed changes

aajisaka merged commit 4ffec79 into apache:trunk Dec 8, 2020

HDFS-15712. Upgrade googletest to 1.10.0 #2523

HDFS-15712. Upgrade googletest to 1.10.0 #2523

Uh oh!

Conversation

GauthamBanasandra commented Dec 5, 2020

Uh oh!

hadoop-yetus commented Dec 5, 2020

Uh oh!

hadoop-yetus commented Dec 6, 2020

Uh oh!

hadoop-yetus commented Dec 6, 2020

Uh oh!

GauthamBanasandra commented Dec 6, 2020

Uh oh!

GauthamBanasandra commented Dec 6, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aajisaka left a comment

Choose a reason for hiding this comment

Uh oh!

GauthamBanasandra commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

GauthamBanasandra commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

aajisaka commented Dec 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants