YARN-10491: Fix deprecation warnings in SLSWebApp.java #2519

ankitk-me · 2020-12-04T08:57:33Z

What? :: Fix deprecation warnings in SLSWebApp.java & TestSLSWebApp.java

toString(URI uri) Deprecated.

Use toString(URI, Charset) instead.

readFileToString(File file) Deprecated.

Use readFileToString(File, Charset) instead.

@aajisaka Can you please review this?

Thanks!

hadoop-yetus · 2020-12-04T10:20:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 30s		trunk passed
+1 💚	compile	0m 25s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 24s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 20s		trunk passed
+1 💚	mvnsite	0m 27s		trunk passed
+1 💚	shadedclient	18m 2s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 24s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 22s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 47s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 44s		trunk passed
			_ Patch Compile Tests _
-1 ❌	mvninstall	0m 15s	/patch-mvninstall-hadoop-tools_hadoop-sls.txt	hadoop-sls in the patch failed.
-1 ❌	compile	0m 16s	/patch-compile-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt	hadoop-sls in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌	javac	0m 16s	/patch-compile-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt	hadoop-sls in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌	compile	0m 15s	/patch-compile-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt	hadoop-sls in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
-1 ❌	javac	0m 15s	/patch-compile-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt	hadoop-sls in the patch failed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.
+1 💚	checkstyle	0m 12s		the patch passed
-1 ❌	mvnsite	0m 16s	/patch-mvnsite-hadoop-tools_hadoop-sls.txt	hadoop-sls in the patch failed.
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	16m 57s		patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 18s	/patch-javadoc-hadoop-tools_hadoop-sls-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt	hadoop-sls in the patch failed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.
-1 ❌	javadoc	0m 19s	/diff-javadoc-javadoc-hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt	hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 generated 1 new + 37 unchanged - 0 fixed = 38 total (was 37)
-1 ❌	findbugs	0m 19s	/patch-findbugs-hadoop-tools_hadoop-sls.txt	hadoop-sls in the patch failed.
			_ Other Tests _
-1 ❌	unit	0m 18s	/patch-unit-hadoop-tools_hadoop-sls.txt	hadoop-sls in the patch failed.
+1 💚	asflicense	0m 29s		The patch does not generate ASF License warnings.
		81m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/1/artifact/out/Dockerfile
GITHUB PR	#2519
JIRA Issue	YARN-10491
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 794c1b741f55 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e2c1268`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/1/testReport/
Max. process+thread count	597 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka · 2020-12-04T10:33:07Z

hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/web/SLSWebApp.java

 @Unstable
 public class SLSWebApp extends HttpServlet {
  private static final long serialVersionUID = 1905162041950251407L;
+  private static final Charset UTF8 = Charset.forName("UTF-8");


If you use Charset.forName(String), you need to catch some exceptions. We can avoid catching exceptions by using StandardCharsets.UTF-8.

hadoop-yetus · 2020-12-04T17:44:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	31m 7s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 54s		trunk passed
+1 💚	compile	0m 26s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 23s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 19s		trunk passed
+1 💚	mvnsite	0m 27s		trunk passed
+1 💚	shadedclient	17m 53s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 24s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 23s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 46s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 44s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 20s		hadoop-tools_hadoop-sls-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	compile	0m 17s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 17s		hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	checkstyle	0m 12s		the patch passed
+1 💚	mvnsite	0m 20s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	16m 48s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	0m 47s		the patch passed
			_ Other Tests _
-1 ❌	unit	11m 48s	/patch-unit-hadoop-tools_hadoop-sls.txt	hadoop-sls in the patch passed.
+1 💚	asflicense	0m 29s		The patch does not generate ASF License warnings.
		120m 59s

Reason	Tests
Failed junit tests	hadoop.yarn.sls.appmaster.TestAMSimulator

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/2/artifact/out/Dockerfile
GITHUB PR	#2519
JIRA Issue	YARN-10491
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux ba07bad2d4ee 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e2c1268`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/2/testReport/
Max. process+thread count	513 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

ankitk-me · 2020-12-04T17:50:46Z

Hey @aajisaka, Thank you for your review.

As suggested, I have added StandardCharsets.UTF_8 instead of Charset.forName(String). Can you please review?

Thanks!

hadoop-yetus · 2020-12-07T11:13:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 12s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 23s		trunk passed
+1 💚	compile	0m 25s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 23s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 19s		trunk passed
+1 💚	mvnsite	0m 27s		trunk passed
+1 💚	shadedclient	17m 55s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 23s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 47s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 44s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 20s		hadoop-tools_hadoop-sls-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	compile	0m 18s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 18s		hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
-0 ⚠️	checkstyle	0m 13s	/diff-checkstyle-hadoop-tools_hadoop-sls.txt	hadoop-tools/hadoop-sls: The patch generated 6 new + 14 unchanged - 0 fixed = 20 total (was 14)
+1 💚	mvnsite	0m 20s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	16m 51s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 19s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	0m 47s		the patch passed
			_ Other Tests _
-1 ❌	unit	10m 31s	/patch-unit-hadoop-tools_hadoop-sls.txt	hadoop-sls in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		90m 52s

Reason	Tests
Failed junit tests	hadoop.yarn.sls.appmaster.TestAMSimulator
	hadoop.yarn.sls.TestReservationSystemInvariants

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/3/artifact/out/Dockerfile
GITHUB PR	#2519
JIRA Issue	YARN-10491
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 0165b7a53559 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ad40715`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/3/testReport/
Max. process+thread count	596 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

This reverts commit 6836462.

hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/web/SLSWebApp.java

ankitk-me · 2020-12-07T13:16:42Z

Hey @aajisaka, Suggested change has been done. Thank you for the review.

hadoop-yetus · 2020-12-07T14:49:58Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 41s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	36m 1s		trunk passed
+1 💚	compile	0m 25s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 24s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 20s		trunk passed
+1 💚	mvnsite	0m 27s		trunk passed
+1 💚	shadedclient	17m 47s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 23s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 45s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 44s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 21s		hadoop-tools_hadoop-sls-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	compile	0m 17s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 17s		hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
-0 ⚠️	checkstyle	0m 12s	/diff-checkstyle-hadoop-tools_hadoop-sls.txt	hadoop-tools/hadoop-sls: The patch generated 6 new + 14 unchanged - 0 fixed = 20 total (was 14)
+1 💚	mvnsite	0m 20s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	17m 13s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 20s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	0m 46s		the patch passed
			_ Other Tests _
+1 💚	unit	11m 52s		hadoop-sls in the patch passed.
+1 💚	asflicense	0m 28s		The patch does not generate ASF License warnings.
		93m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/5/artifact/out/Dockerfile
GITHUB PR	#2519
JIRA Issue	YARN-10491
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 79ba89100251 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `da1ea25`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/5/testReport/
Max. process+thread count	511 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/5/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-12-07T14:54:11Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 5s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 10s		trunk passed
+1 💚	compile	0m 37s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 24s		trunk passed
+1 💚	mvnsite	0m 36s		trunk passed
+1 💚	shadedclient	21m 48s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 34s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 29s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	1m 1s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 56s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 31s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 26s		hadoop-tools_hadoop-sls-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 23s		hadoop-tools_hadoop-sls-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 generated 0 new + 0 unchanged - 6 fixed = 0 total (was 6)
+1 💚	checkstyle	0m 14s		the patch passed
+1 💚	mvnsite	0m 26s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	19m 32s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 30s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 26s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	1m 16s		the patch passed
			_ Other Tests _
-1 ❌	unit	12m 20s	/patch-unit-hadoop-tools_hadoop-sls.txt	hadoop-sls in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		108m 48s

Reason	Tests
Failed junit tests	hadoop.yarn.sls.appmaster.TestAMSimulator

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/4/artifact/out/Dockerfile
GITHUB PR	#2519
JIRA Issue	YARN-10491
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 7b11eb280ca9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `da1ea25`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/4/testReport/
Max. process+thread count	619 (vs. ulimit of 5500)
modules	C: hadoop-tools/hadoop-sls U: hadoop-tools/hadoop-sls
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2519/4/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka

LGTM

aajisaka · 2020-12-08T08:16:52Z

TestAMSimulator: https://issues.apache.org/jira/browse/YARN-9843

ankitk-me · 2020-12-08T16:46:08Z

Hey @szilard-nemeth, Can you please review this?

Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit aaf9e3d)

YARN-10491: Fix deprecation warnings in SLSWebApp.java

056f3af

aajisaka reviewed Dec 4, 2020

View reviewed changes

Using StandardCharsets.UTF_8

8d5e73b

Removing Charset variable

6836462

Revert "Removing Charset variable"

d0f00ef

This reverts commit 6836462.

aajisaka reviewed Dec 7, 2020

View reviewed changes

hadoop-tools/hadoop-sls/src/main/java/org/apache/hadoop/yarn/sls/web/SLSWebApp.java Outdated Show resolved Hide resolved

Keeping import order

0b82d93

aajisaka approved these changes Dec 8, 2020

View reviewed changes

aajisaka merged commit aaf9e3d into apache:trunk Dec 9, 2020

aajisaka pushed a commit that referenced this pull request Dec 9, 2020

YARN-10491. Fix deprecation warnings in SLSWebApp.java (#2519)

f04a9df

Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit aaf9e3d)

aajisaka pushed a commit that referenced this pull request Dec 9, 2020

YARN-10491. Fix deprecation warnings in SLSWebApp.java (#2519)

1570bdd

Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit aaf9e3d)

aajisaka pushed a commit that referenced this pull request Dec 9, 2020

YARN-10491. Fix deprecation warnings in SLSWebApp.java (#2519)

b89aff6

Signed-off-by: Akira Ajisaka <[email protected]> (cherry picked from commit aaf9e3d)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-10491: Fix deprecation warnings in SLSWebApp.java #2519

YARN-10491: Fix deprecation warnings in SLSWebApp.java #2519

Uh oh!

ankitk-me commented Dec 4, 2020

Uh oh!

hadoop-yetus commented Dec 4, 2020

Uh oh!

aajisaka Dec 4, 2020

Uh oh!

hadoop-yetus commented Dec 4, 2020

Uh oh!

ankitk-me commented Dec 4, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

Uh oh!

ankitk-me commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

aajisaka left a comment

Uh oh!

aajisaka commented Dec 8, 2020

Uh oh!

ankitk-me commented Dec 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

YARN-10491: Fix deprecation warnings in SLSWebApp.java #2519

YARN-10491: Fix deprecation warnings in SLSWebApp.java #2519

Uh oh!

Conversation

ankitk-me commented Dec 4, 2020

Uh oh!

hadoop-yetus commented Dec 4, 2020

Uh oh!

aajisaka Dec 4, 2020

Choose a reason for hiding this comment

Uh oh!

hadoop-yetus commented Dec 4, 2020

Uh oh!

ankitk-me commented Dec 4, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

Uh oh!

ankitk-me commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

aajisaka left a comment

Choose a reason for hiding this comment

Uh oh!

aajisaka commented Dec 8, 2020

Uh oh!

ankitk-me commented Dec 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants