HDFS-15711. Add Metrics to HttpFS Server. #2521

amahussein · 2020-12-05T00:14:47Z

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

hadoop-yetus · 2020-12-05T02:05:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	26m 20s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	34m 26s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 27s		trunk passed
+1 💚	mvnsite	0m 39s		trunk passed
+1 💚	shadedclient	16m 44s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 29s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 27s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 50s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 49s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 25s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 20s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 20s		the patch passed
-0 ⚠️	checkstyle	0m 17s	/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt	hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 3 new + 49 unchanged - 0 fixed = 52 total (was 49)
+1 💚	mvnsite	0m 29s		the patch passed
-1 ❌	whitespace	0m 0s	/whitespace-eol.txt	The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedclient	15m 13s		patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 24s	/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04.txt	hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkUbuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)
-1 ❌	javadoc	0m 23s	/diff-javadoc-javadoc-hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01.txt	hadoop-hdfs-project_hadoop-hdfs-httpfs-jdkPrivateBuild-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~~18.04-b01 generated 1 new + 55 unchanged - 0 fixed = 56 total (was 55)
-1 ❌	findbugs	0m 50s	/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-httpfs.html	hadoop-hdfs-project/hadoop-hdfs-httpfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
			_ Other Tests _
+1 💚	unit	5m 19s		hadoop-hdfs-httpfs in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		109m 8s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs-httpfs
	Write to static field org.apache.hadoop.fs.http.server.HttpFSServerWebApp.metrics from instance method org.apache.hadoop.fs.http.server.HttpFSServerWebApp.init() At HttpFSServerWebApp.java:from instance method org.apache.hadoop.fs.http.server.HttpFSServerWebApp.init() At HttpFSServerWebApp.java:[line 111]

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/1/artifact/out/Dockerfile
GITHUB PR	#2521
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 4a0c4347a290 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7dda804`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/1/testReport/
Max. process+thread count	717 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-12-05T03:58:23Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 29s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 59s		trunk passed
+1 💚	compile	0m 31s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 27s		trunk passed
+1 💚	mvnsite	0m 40s		trunk passed
+1 💚	shadedclient	16m 5s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 30s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 26s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 48s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 48s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 25s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 21s		the patch passed
-0 ⚠️	checkstyle	0m 16s	/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs-httpfs.txt	hadoop-hdfs-project/hadoop-hdfs-httpfs: The patch generated 2 new + 49 unchanged - 0 fixed = 51 total (was 49)
+1 💚	mvnsite	0m 29s		the patch passed
-1 ❌	whitespace	0m 0s	/whitespace-eol.txt	The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedclient	14m 41s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 23s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	0m 48s		the patch passed
			_ Other Tests _
+1 💚	unit	5m 18s		hadoop-hdfs-httpfs in the patch passed.
+1 💚	asflicense	0m 35s		The patch does not generate ASF License warnings.
		80m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/2/artifact/out/Dockerfile
GITHUB PR	#2521
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 5401478f2ba9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `7dda804`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/2/testReport/
Max. process+thread count	716 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-12-07T16:36:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	31m 18s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	35m 14s		trunk passed
+1 💚	compile	0m 27s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 24s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 22s		trunk passed
+1 💚	mvnsite	0m 35s		trunk passed
+1 💚	shadedclient	18m 7s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 22s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 45s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 42s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 22s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 21s		the patch passed
+1 💚	compile	0m 18s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 18s		the patch passed
+1 💚	checkstyle	0m 13s		the patch passed
+1 💚	mvnsite	0m 26s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	16m 39s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 21s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 20s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	0m 49s		the patch passed
			_ Other Tests _
+1 💚	unit	5m 6s		hadoop-hdfs-httpfs in the patch passed.
+1 💚	asflicense	0m 29s		The patch does not generate ASF License warnings.
		116m 18s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/3/artifact/out/Dockerfile
GITHUB PR	#2521
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 2fdc2afda5a0 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `da1ea25`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/3/testReport/
Max. process+thread count	708 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jbrennan333

Thanks @amahussein. See inline comments.

...ct/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServerWebApp.java

jbrennan333 · 2020-12-08T22:17:05Z

...ject/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java

It's not clear to me why we need this metricsGetter. Seems to add complexity with no added value. Can't you just call the appropriate HttpFSServerWebApp.get().getMetrics().get* function wherever this is used?

I found that the best way to check the metrics is to inject code in getStatus. This reduced the diff significantly. getStatus() accepts the cmd as a string, so adding if-then-else for each cmd will be more difficult to maintain. Finally, it is easier to add a command to the metricsGetter to extend the set of tests.
Also, the default callable saves NPE in case the command is not mapped to a metricGetter.

Oh I see that makes sense for getStatus(). I was looking at testMkdirs() when I was trying to understand why you were using it, and it didn't make sense to me. I don't think you should use the metricsGetter in testMkdirs(), or at least not use getOrDefault() - the default case here does not make sense - it renders that part of the test meaningless. I'd prefer to just get the ops directly in this case.

Thanks @jbrennan333 .
This makes sense.
I fixed testMkdirs, createDirWithHttp, testGlobFilter, and testHdfsAccess

jbrennan333 · 2020-12-08T22:17:57Z

...ject/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServer.java

Seems like extra blank lines were added by accident.

...ct/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServerWebApp.java

hadoop-yetus · 2020-12-09T01:39:13Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 32s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 45s		trunk passed
+1 💚	compile	0m 33s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 29s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 26s		trunk passed
+1 💚	mvnsite	0m 39s		trunk passed
+1 💚	shadedclient	16m 18s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 30s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 28s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 49s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 48s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 26s		the patch passed
+1 💚	compile	0m 24s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 24s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 21s		the patch passed
+1 💚	checkstyle	0m 16s		the patch passed
+1 💚	mvnsite	0m 29s		the patch passed
+1 💚	whitespace	0m 0s		The patch has no whitespace issues.
+1 💚	shadedclient	15m 6s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 25s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 24s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	0m 49s		the patch passed
			_ Other Tests _
+1 💚	unit	5m 20s		hadoop-hdfs-httpfs in the patch passed.
+1 💚	asflicense	0m 34s		The patch does not generate ASF License warnings.
		81m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/4/artifact/out/Dockerfile
GITHUB PR	#2521
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 7bceb921af61 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `01383a2`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/4/testReport/
Max. process+thread count	719 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/4/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-12-10T19:03:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 30s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚		0m 0s	test4tests	The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	32m 29s		trunk passed
+1 💚	compile	0m 32s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	compile	0m 30s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	checkstyle	0m 28s		trunk passed
+1 💚	mvnsite	0m 40s		trunk passed
+1 💚	shadedclient	17m 7s		branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 28s		trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 26s		trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗	spotbugs	0m 50s		Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	0m 47s		trunk passed
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 25s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javac	0m 23s		the patch passed
+1 💚	compile	0m 21s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	javac	0m 21s		the patch passed
+1 💚	checkstyle	0m 17s		the patch passed
+1 💚	mvnsite	0m 28s		the patch passed
+1 💚	whitespace	0m 1s		The patch has no whitespace issues.
+1 💚	shadedclient	15m 5s		patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 22s		the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚	javadoc	0m 22s		the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚	findbugs	0m 47s		the patch passed
			_ Other Tests _
+1 💚	unit	5m 21s		hadoop-hdfs-httpfs in the patch passed.
+1 💚	asflicense	0m 32s		The patch does not generate ASF License warnings.
		81m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/5/artifact/out/Dockerfile
GITHUB PR	#2521
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 406d6f7b4e04 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `c2cecfc`
Default Java	Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/5/testReport/
Max. process+thread count	719 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2521/5/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

jbrennan333

Thanks for the update @amahussein!
+1 this looks good to me.

…d Hussein and Kihwal Lee

amahussein force-pushed the hdfs-15711 branch from 34be9cf to c2cc329 Compare December 7, 2020 14:38

jbrennan333 requested changes Dec 8, 2020

View reviewed changes

amahussein force-pushed the hdfs-15711 branch from c2cc329 to b833540 Compare December 9, 2020 00:17

amahussein added 3 commits December 10, 2020 11:39

HDFS-15711. Add Metrics to HttpFS Server.

06a3276

HDFS-15711. code reviews.

dfa6bc9

HDFS-15711. fix mkdir ops getter.

989b16e

amahussein force-pushed the hdfs-15711 branch from b833540 to 989b16e Compare December 10, 2020 17:41

jbrennan333 approved these changes Dec 10, 2020

View reviewed changes

jbrennan333 merged commit 3ec01b1 into apache:trunk Dec 10, 2020

asfgit pushed a commit that referenced this pull request Dec 10, 2020

HDFS-15711. Add Metrics to HttpFS Server. (#2521) Contributed by Ahme…

27e455a

…d Hussein and Kihwal Lee

asfgit pushed a commit that referenced this pull request Dec 10, 2020

HDFS-15711. Add Metrics to HttpFS Server. (#2521) Contributed by Ahme…

76316c4

…d Hussein and Kihwal Lee

asfgit pushed a commit that referenced this pull request Dec 10, 2020

HDFS-15711. Add Metrics to HttpFS Server. (#2521) Contributed by Ahme…

777f426

…d Hussein and Kihwal Lee

HDFS-15711. Add Metrics to HttpFS Server. #2521

HDFS-15711. Add Metrics to HttpFS Server. #2521

Uh oh!

Conversation

amahussein commented Dec 5, 2020

NOTICE

Uh oh!

hadoop-yetus commented Dec 5, 2020

Uh oh!

hadoop-yetus commented Dec 5, 2020

Uh oh!

hadoop-yetus commented Dec 7, 2020

Uh oh!

jbrennan333 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbrennan333 Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

amahussein Dec 9, 2020

Choose a reason for hiding this comment

Uh oh!

jbrennan333 Dec 9, 2020

Choose a reason for hiding this comment

Uh oh!

amahussein Dec 10, 2020

Choose a reason for hiding this comment

Uh oh!

jbrennan333 Dec 8, 2020

Choose a reason for hiding this comment

Uh oh!

amahussein Dec 9, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hadoop-yetus commented Dec 9, 2020

Uh oh!

hadoop-yetus commented Dec 10, 2020

Uh oh!

jbrennan333 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants