Skip to content

HDFS-15694. Avoid calling UpdateHeartBeatState inside DataNodeDescriptor #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jbrennan333 merged 1 commit into from
Dec 1, 2020
Merged

HDFS-15694. Avoid calling UpdateHeartBeatState inside DataNodeDescriptor #2487

jbrennan333 merged 1 commit into from
Dec 1, 2020

Conversation

@amahussein
Copy link
Contributor

@amahussein amahussein commented Nov 24, 2020

NOTICE

Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute

@amahussein amahussein changed the title HADOOP-17393. Avoid calling UpdateHeartBeatState inside DataNodeDescriptor HDFS-15694. Avoid calling UpdateHeartBeatState inside DataNodeDescriptor Nov 24, 2020
@hadoop-yetus
Copy link

hadoop-yetus commented Nov 24, 2020

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 47s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 38m 52s trunk passed
+1 💚 compile 1m 41s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 1m 22s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 0m 49s trunk passed
+1 💚 mvnsite 1m 31s trunk passed
+1 💚 shadedclient 21m 13s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 4s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 42s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 3m 37s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 34s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 20s the patch passed
+1 💚 compile 1m 27s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 1m 27s the patch passed
+1 💚 compile 1m 18s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 1m 18s the patch passed
+1 💚 checkstyle 0m 50s the patch passed
+1 💚 mvnsite 1m 31s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 19m 20s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 56s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 30s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 3m 31s the patch passed
_ Other Tests _
-1 ❌ unit 100m 45s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
207m 49s
Reason Tests
Failed junit tests hadoop.hdfs.TestReplaceDatanodeOnFailure
hadoop.hdfs.TestSafeModeWithStripedFile
hadoop.hdfs.TestBlockTokenWrappingQOP
hadoop.hdfs.server.namenode.ha.TestUpdateBlockTailing
hadoop.hdfs.server.balancer.TestBalancer
hadoop.hdfs.TestErasureCodingMultipleRacks
hadoop.hdfs.TestClientProtocolForPipelineRecovery
hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics
hadoop.hdfs.TestDistributedFileSystem
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.TestDecommissionWithStriped
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/2/artifact/out/Dockerfile
GITHUB PR #2487
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux b5d74bebd747 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c4ba0ab
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/2/testReport/
Max. process+thread count 4749 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Nov 24, 2020

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 26m 24s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 33m 42s trunk passed
+1 💚 compile 1m 18s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 1m 13s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 0m 48s trunk passed
+1 💚 mvnsite 1m 25s trunk passed
+1 💚 shadedclient 21m 14s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 2s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 35s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 3m 34s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 31s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 22s the patch passed
+1 💚 compile 1m 34s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 1m 34s the patch passed
+1 💚 compile 1m 13s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 1m 13s the patch passed
+1 💚 checkstyle 0m 49s the patch passed
+1 💚 mvnsite 1m 25s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 18m 46s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 58s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 39s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 4m 5s the patch passed
_ Other Tests _
-1 ❌ unit 126m 57s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
254m 5s
Reason Tests
Failed junit tests hadoop.hdfs.TestDFSMkdirs
hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy
hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
hadoop.hdfs.client.impl.TestBlockReaderLocal
hadoop.hdfs.TestFileChecksumCompositeCrc
hadoop.hdfs.TestDistributedFileSystemWithECFileWithRandomECPolicy
hadoop.hdfs.TestMultipleNNPortQOP
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.TestReadStripedFileWithDecoding
hadoop.hdfs.TestErasureCodingPolicies
hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
hadoop.hdfs.TestViewDistributedFileSystem
hadoop.hdfs.server.balancer.TestBalancer
hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/1/artifact/out/Dockerfile
GITHUB PR #2487
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux bc9d6a0c7d61 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / c4ba0ab
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/1/testReport/
Max. process+thread count 4188 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

hadoop-yetus commented Nov 30, 2020

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 0m 0s test4tests The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+1 💚 mvninstall 32m 50s trunk passed
+1 💚 compile 1m 22s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 compile 1m 15s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 checkstyle 0m 50s trunk passed
+1 💚 mvnsite 1m 19s trunk passed
+1 💚 shadedclient 17m 32s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 55s trunk passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 27s trunk passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+0 🆗 spotbugs 3m 7s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 3m 5s trunk passed
_ Patch Compile Tests _
+1 💚 mvninstall 1m 9s the patch passed
+1 💚 compile 1m 13s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javac 1m 13s the patch passed
+1 💚 compile 1m 4s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 javac 1m 4s the patch passed
+1 💚 checkstyle 0m 39s the patch passed
+1 💚 mvnsite 1m 9s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 37s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 0m 48s the patch passed with JDK Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04
+1 💚 javadoc 1m 19s the patch passed with JDK Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
+1 💚 findbugs 3m 4s the patch passed
_ Other Tests _
-1 ❌ unit 96m 8s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
185m 6s
Reason Tests
Failed junit tests hadoop.hdfs.server.balancer.TestBalancer
hadoop.hdfs.TestRollingUpgrade
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/3/artifact/out/Dockerfile
GITHUB PR #2487
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 1dcdcf3af76c 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 44910b5
Default Java Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.9.1+1-Ubuntu-0ubuntu1.18.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_275-8u275-b01-0ubuntu1~18.04-b01
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/3/testReport/
Max. process+thread count 3969 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/3/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@amahussein
Copy link
Contributor Author

amahussein commented Dec 1, 2020

https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2487/3/testReport/

I have checked the classes TestBalancer and TestRollingUpgrade which seem to be intermittent in the qbt reports.
I tested them locally and they pass.
I will check if a new jira needs to be filed for those two tests.

jbrennan333
jbrennan333 approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@jbrennan333 jbrennan333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 this looks good to me. We have been running with this change internally on production clusters for several years.

@jbrennan333 jbrennan333 merged commit 918ba9e into apache:trunk Dec 1, 2020
asfgit pushed a commit that referenced this pull request Dec 1, 2020
@amahussein @jbrennan333
HDFS-15694. Avoid calling UpdateHeartBeatState inside DataNodeDescrip…
a660714 
…tor. (#2487) Contributed by Kuhu Shukla and Ahmed Hussein

(cherry picked from commit 918ba9e)
asfgit pushed a commit that referenced this pull request Dec 1, 2020
@amahussein @jbrennan333
HDFS-15694. Avoid calling UpdateHeartBeatState inside DataNodeDescrip…
625f85f 
…tor. (#2487) Contributed by Kuhu Shukla and Ahmed Hussein

(cherry picked from commit 918ba9e)
asfgit pushed a commit that referenced this pull request Dec 1, 2020
@amahussein @jbrennan333
HDFS-15694. Avoid calling UpdateHeartBeatState inside DataNodeDescrip…
2331f86 
…tor. (#2487) Contributed by Kuhu Shukla and Ahmed Hussein

(cherry picked from commit 918ba9e)
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@amahussein
HDFS-15694. Avoid calling UpdateHeartBeatState inside DataNodeDescrip…
6a8ad41 
…tor. (apache#2487) Contributed by Kuhu Shukla and Ahmed Hussein

(cherry picked from commit 918ba9e)
(cherry picked from commit 2331f86)
Change-Id: I3773ea20f6b04e83b92de3a5663a43fdd8340b80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbrennan333 jbrennan333 jbrennan333 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amahussein @hadoop-yetus @jbrennan333