`jellyfish-wallet-encrypted` by ivan-zynesis · Pull Request #344 · DeFiCh/jellyfishsdk

ivan-zynesis · 2021-06-04T04:36:37Z

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

sub package, library to encrypt mnemonic seed and store
any private key usage require caller to decrypt storage using a passphrase

Which issue(s) does this PR fixes?:

Fixes #133

Additional comments?:

wait for dependencies merged, will ease the reading
trimmed down changes into series of PRs
#331 (merged) -> #369 (merged) -> #371 then this (put this into draft first)

qlty-cloud-legacy · 2021-06-04T04:36:57Z

Code Climate has analyzed commit c7d51bd and detected 0 issues on this pull request.

View more on Code Climate.

netlify · 2021-06-04T04:37:50Z

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 90e1195

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60f536d8871ddc00073397fd

😎 Browse the preview: https://deploy-preview-344--jellyfish-defi.netlify.app

github-actions · 2021-06-04T04:40:44Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/jellyfish/dist/index.umd.js	21.37 KB (0%)	428 ms (0%)	187 ms (-3.45% 🔽)	615 ms

packages/jellyfish-wallet-encrypted/package.json

packages/jellyfish-crypto/__tests__/aes256.test.ts

packages/jellyfish-crypto/src/aes256.ts

codecov · 2021-06-04T07:54:09Z

Codecov Report

Merging #344 (d8366b1) into main (00986ae) will increase coverage by 4.47%.
The diff coverage is 98.41%.

❗ Current head d8366b1 differs from pull request most recent head c7d51bd. Consider uploading reports for the commit c7d51bd to get more accurate results

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   92.98%   97.46%   +4.47%     
==========================================
  Files          10      105      +95     
  Lines         171     3071    +2900     
  Branches       19      300     +281     
==========================================
+ Hits          159     2993    +2834     
- Misses         12       78      +66

Impacted Files	Coverage Δ
packages/jellyfish-crypto/src/hash.ts	`100.00% <ø> (ø)`
packages/jellyfish-crypto/src/index.ts	`100.00% <ø> (ø)`
packages/jellyfish-crypto/src/wif.ts	`100.00% <ø> (ø)`
packages/jellyfish-json/src/index.ts	`93.10% <ø> (ø)`
packages/jellyfish-json/src/remap.ts	`96.96% <ø> (ø)`
packages/jellyfish-network/src/index.ts	`84.61% <ø> (ø)`
...ackages/jellyfish-transaction-builder/src/index.ts	`100.00% <ø> (ø)`
...llyfish-transaction-builder/src/txn/txn_builder.ts	`96.15% <ø> (ø)`
...transaction-builder/src/txn/txn_builder_account.ts	`100.00% <ø> (ø)`
...ish-transaction-builder/src/txn/txn_builder_dex.ts	`100.00% <ø> (ø)`
... and 142 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90bdb00...c7d51bd. Read the comment docs.

packages/jellyfish-wallet-encrypted/example/demo.ts

qlty-cloud-legacy

The PR diff size of 8935 lines exceeds the maximum allowed for the inline comments feature.

qlty-cloud-legacy

The PR diff size of 8940 lines exceeds the maximum allowed for the inline comments feature.

…scrypt-storage

fuxingloh · 2021-07-21T03:15:03Z

I am reviewing this, give me some time to understand its integrative behavior

* pulled changes from #344 * refactor jellyfish-wallet-encrypted encryption layer for a cleaner abstraction pattern * fixed scrypt_provider import * refactor encryption to just scrypt

fuxingloh · 2021-07-22T10:19:25Z

Closed in favor of #480

* Add basic indexer and model * Working implementation, added tests * Added changes to masternode controller and tests * Fixed test * Fix flakey test * Added post eunos paya test * Improve code coverage * Improved test coverage for controller * Fixed new naming * Add timelock * Fix test * Fix tests * Update packages/whale-api-client/__tests__/api/masternodes.test.ts Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com> * Update src/module.api/masternode.controller.ts Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com> * Make resign tx optional * Made resign struct optional * Fix tests * Fix tests * Make tx not optional * This is better * Fix test Co-authored-by: Fuxing Loh <4266087+fuxingloh@users.noreply.github.com>

ivan added 3 commits June 2, 2021 14:38

add an aes256 lib, required for scrypt later

555d36d

remove duplicated test

3f85f54

minor jsdoc update, add ip ref

d74cf26

ivan-zynesis requested review from canonbrother, fuxingloh and jingyi2811 as code owners June 4, 2021 04:36

defichain-bot added kind/feature New feature request area/jellyfish-crypto area/workflow labels Jun 4, 2021

defichain-bot assigned ivan-zynesis Jun 4, 2021

ivan-zynesis changed the title ~~Feature/mnemonic wallet/scrypt storage~~ jellyfish-wallet-encrypted Jun 4, 2021

ivan-zynesis marked this pull request as draft June 4, 2021 04:39

ivan-zynesis marked this pull request as ready for review June 4, 2021 05:09

ivan-zynesis commented Jun 4, 2021

View reviewed changes

packages/jellyfish-wallet-encrypted/package.json Outdated Show resolved Hide resolved

ivan-zynesis commented Jun 4, 2021

View reviewed changes

packages/jellyfish-crypto/__tests__/aes256.test.ts Outdated Show resolved Hide resolved

ivan-zynesis commented Jun 4, 2021

View reviewed changes

packages/jellyfish-crypto/src/aes256.ts Outdated Show resolved Hide resolved

ivan-zynesis marked this pull request as draft June 4, 2021 08:25

ivan-zynesis commented Jun 4, 2021

View reviewed changes

packages/jellyfish-wallet-encrypted/example/demo.ts Outdated Show resolved Hide resolved

ivan added 3 commits June 8, 2021 12:00

remove direct native crypto pkg usage, use browserify libs

a7da375

allow custom iv for aes enc

0e18502

remove invalid npm dev dep

e3fe183

qlty-cloud-legacy bot reviewed Jun 8, 2021

View reviewed changes

ivan-zynesis marked this pull request as ready for review June 8, 2021 04:39

change iv arg from buffer to () => buffer

8df8329

qlty-cloud-legacy bot reviewed Jun 8, 2021

View reviewed changes

defichain-bot added area/jellyfish-api-jsonrpc and removed area/jellyfish-crypto labels Jul 16, 2021

ivan added 2 commits July 16, 2021 17:04

passphrase only need when get pub/priv key, sign/verify

b729a36

remove cast type

a156024

defichain-bot removed the area/jellyfish-api-jsonrpc label Jul 16, 2021

Refactoring and clean up, added passphrase input interface

e1cfef8

ivan-zynesis marked this pull request as ready for review July 16, 2021 22:39

ivan added 6 commits July 17, 2021 06:43

remove unnecessary setter call in consturctor

66ef446

fix invalidtype cast

01278e5

remove husky gitigonore (no longer needed)

9207a6f

address some change request

60e138d

remove outdate husky file, updated package-lock

28a1f89

Merge branch 'mnemonic-seed-encryption' into feature/mnemonic-wallet/…

03667d4

…scrypt-storage

defichain-bot added the area/jellyfish-wallet-encrypted label Jul 19, 2021

Merge branch 'main' into feature/mnemonic-wallet/scrypt-storage

90e1195

defichain-bot removed area/website area/workflow labels Jul 19, 2021

ivan added 2 commits July 19, 2021 16:27

rename file, fix import

0744d4b

add back missed out changes

c7d51bd

fuxingloh self-assigned this Jul 21, 2021

fuxingloh added a commit that referenced this pull request Jul 21, 2021

pulled changes from #344

f7569ae

fuxingloh mentioned this pull request Jul 22, 2021

jellyfish-wallet-encrypted hd_node.ts implementation #480

Merged

fuxingloh closed this Jul 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`jellyfish-wallet-encrypted`#344

`jellyfish-wallet-encrypted`#344
ivan-zynesis wants to merge 83 commits intomainfrom
feature/mnemonic-wallet/scrypt-storage

ivan-zynesis commented Jun 4, 2021 •

edited by fuxingloh

Loading

Uh oh!

qlty-cloud-legacy bot commented Jun 4, 2021 •

edited

Loading

Uh oh!

netlify bot commented Jun 4, 2021 •

edited

Loading

Uh oh!

github-actions bot commented Jun 4, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 4, 2021 •

edited

Loading

Uh oh!

Uh oh!

qlty-cloud-legacy bot left a comment

Uh oh!

qlty-cloud-legacy bot left a comment

Uh oh!

fuxingloh commented Jul 21, 2021 •

edited

Loading

Uh oh!

fuxingloh commented Jul 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ivan-zynesis commented Jun 4, 2021 • edited by fuxingloh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What kind of PR is this?:

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Additional comments?:

Uh oh!

qlty-cloud-legacy bot commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jun 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

Uh oh!

fuxingloh commented Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fuxingloh commented Jul 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ivan-zynesis commented Jun 4, 2021 •

edited by fuxingloh

Loading

qlty-cloud-legacy bot commented Jun 4, 2021 •

edited

Loading

netlify bot commented Jun 4, 2021 •

edited

Loading

github-actions bot commented Jun 4, 2021 •

edited

Loading

codecov bot commented Jun 4, 2021 •

edited

Loading

fuxingloh commented Jul 21, 2021 •

edited

Loading