jellyfish-transaction-signature

[ivan-zynesis]

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

To remove crypto dependencies from jellyfish-transaction
to become pure transaction object-buffer (de)composer

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

fixing build issue, to replace #359

[qlty-cloud-legacy]

Code Climate has analyzed commit b7d8473 and detected 0 issues on this pull request.

View more on Code Climate.

[github-actions]

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
packages/jellyfish/dist/index.umd.js	20.3 KB (0%)	407 ms (0%)	152 ms (-1.23% 🔽)	558 ms

[codecov]

Codecov Report

Merging #369 (b7d8473) into main (c1c6335) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #369   +/-   ##
=======================================
  Coverage   97.15%   97.15%           
=======================================
  Files          92       94    +2     
  Lines        2670     2670           
  Branches      342      344    +2     
=======================================
  Hits         2594     2594           
  Misses         76       76           

Impacted Files	Coverage Δ
packages/jellyfish-transaction/src/index.ts	100.00% <ø> (ø)
packages/jellyfish-transaction/src/tx_segwit.ts	100.00% <ø> (ø)
...llyfish-transaction-builder/src/txn/txn_builder.ts	96.15% <100.00%> (+0.07%)	⬆️
...kages/jellyfish-transaction-signature/src/index.ts	100.00% <100.00%> (ø)
...ellyfish-transaction-signature/src/tx_signature.ts	97.29% <100.00%> (ø)
packages/jellyfish-transaction/src/tx.ts	100.00% <100.00%> (ø)
packages/jellyfish-wallet-mnemonic/src/mnemonic.ts	98.00% <100.00%> (+0.04%)	⬆️
packages/jellyfish-api-core/src/category/oracle.ts	100.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1c6335...b7d8473. Read the comment docs.

[netlify]

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: a398c4e

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60c2d9f7c1e1cb000860950f

😎 Browse the preview: https://deploy-preview-369--jellyfish-defi.netlify.app

[fuxingloh]

I will do a proper review/check after AES get merged in

[fuxingloh]

looks good, we should remove devDeps