Skip to content

passphrase derivation + encryption + storage lib#371

Merged
fuxingloh merged 73 commits intomainfrom
mnemonic-seed-encryption
Jul 19, 2021
Merged

passphrase derivation + encryption + storage lib#371
fuxingloh merged 73 commits intomainfrom
mnemonic-seed-encryption

Conversation

@ivan-zynesis
Copy link
Contributor

@ivan-zynesis ivan-zynesis commented Jun 11, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

dependency of #344
to serve as a scrypt protected storage, to be used to encrypt and store mnemonic seed which can be unlock using passphrase

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

wait for #331 and #369 (merged)
this is actually worked backward, trimming down code done in 344 to ease review process

@ivan-zynesis ivan-zynesis changed the base branch from main to handpick-jellyfish-tx-signature June 14, 2021 01:44
Base automatically changed from handpick-jellyfish-tx-signature to main June 14, 2021 08:54
@fuxingloh
Copy link
Contributor

Conflicts

@fuxingloh fuxingloh marked this pull request as draft June 14, 2021 16:37
@ivan-zynesis ivan-zynesis changed the title Mnemonic seed encryption and storage lib passphrase derivation + encryption + storage lib Jun 15, 2021
@ivan-zynesis ivan-zynesis marked this pull request as ready for review June 15, 2021 03:33
@fuxingloh fuxingloh self-assigned this Jul 16, 2021
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more JSDoc for a better understanding of what each class does.

Also need to refactor README.md and equivalent as they have channged.

@ivan-zynesis ivan-zynesis requested a review from fuxingloh July 19, 2021 07:24
@fuxingloh fuxingloh merged commit 90bdb00 into main Jul 19, 2021
@fuxingloh fuxingloh deleted the mnemonic-seed-encryption branch July 19, 2021 07:57
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
* Bump @defichain/jellyfish dependencies

* fixed package-lock.json

Co-authored-by: Fuxing Loh <git@fuxing.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants