jellyfish-wallet-encrypted hd_node.ts implementation#480
Merged
Conversation
|
Code Climate has analyzed commit c11a0ad and detected 0 issues on this pull request. View more on Code Climate. |
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #480 +/- ##
==========================================
+ Coverage 97.28% 97.31% +0.02%
==========================================
Files 104 105 +1
Lines 3019 3052 +33
Branches 378 378
==========================================
+ Hits 2937 2970 +33
Misses 82 82
Continue to review full report at Codecov.
|
ivan-zynesis
approved these changes
Jul 22, 2021
monstrobishi
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?:
/kind feature
What this PR does / why we need it:
jellyfish-walletnot to use44'/${COIN_TYPE}'/${account}'/0/0for non-hardened path derivation to allow encrypted wallet implementations to access public key without requiring private key${account}/0/0bip32.test.tsfor better encrypted and mnemonic testingEncryptedDataEncryptedMnemonicHdNodeextendsMnemonicHdNodewith overrides toderiveNodeto use promise-based derivation technique to allow privateKey to be decrypted.EncryptedHdNodeProvidercomes withwordsToEncryptedDatato encrypt a mnemonic words into encrypted format to use withinEncryptedHdNodeProvider. The encrypted version is the hot implementation, where the mnemonic is the cold implementation.You can initialize
EncryptedHdNodeProviderwithEncryptedProviderData,ScryptandPromptPassphrasefor prompting password.Which issue(s) does this PR fixes?:
Fixes #344
Fixes #133