Skip to content

jellyfish-crypto: aes256#331

Merged
fuxingloh merged 11 commits intomainfrom
feature/mnemonic-wallet/passphrase-encrypt-seed
Jun 11, 2021
Merged

jellyfish-crypto: aes256#331
fuxingloh merged 11 commits intomainfrom
feature/mnemonic-wallet/passphrase-encrypt-seed

Conversation

@ivan-zynesis
Copy link
Contributor

@ivan-zynesis ivan-zynesis commented Jun 2, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Dependency of #133 .
Existing lib in found in npm has no TS @types support, so build a simple one directly from crypto.
Simplified implementation, all arg and return are buffer only.

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

@ivan-zynesis ivan-zynesis requested a review from fuxingloh as a code owner June 2, 2021 06:42
@ivan-zynesis ivan-zynesis marked this pull request as draft June 2, 2021 06:42
@defichain-bot defichain-bot added the kind/feature New feature request label Jun 2, 2021
@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jun 2, 2021

Code Climate has analyzed commit d74cf26 and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Jun 2, 2021

✔️ Deploy Preview for jellyfish-defi ready!

🔨 Explore the source changes: 555d36d

🔍 Inspect the deploy log: https://app.netlify.com/sites/jellyfish-defi/deploys/60b72853fc65a60007a99289

😎 Browse the preview: https://deploy-preview-331--jellyfish-defi.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 20.18 KB (0%) 404 ms (0%) 181 ms (+5.77% 🔺) 585 ms

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #331 (f63f539) into main (9dfd345) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   96.92%   97.15%   +0.23%     
==========================================
  Files          89       92       +3     
  Lines        2404     2670     +266     
  Branches      308      342      +34     
==========================================
+ Hits         2330     2594     +264     
- Misses         74       76       +2     
Impacted Files Coverage Δ
packages/jellyfish-crypto/src/aes256.ts 100.00% <100.00%> (ø)
packages/jellyfish-crypto/src/index.ts 100.00% <100.00%> (ø)
...ainers/src/chains/reg_test_container/masternode.ts 94.44% <0.00%> (-3.71%) ⬇️
...kages/testcontainers/src/chains/defid_container.ts 92.92% <0.00%> (-0.83%) ⬇️
packages/jellyfish-api-core/src/index.ts 100.00% <0.00%> (ø)
packages/jellyfish-wallet/src/wallet_account.ts 100.00% <0.00%> (ø)
packages/jellyfish-api-core/src/category/token.ts 100.00% <0.00%> (ø)
packages/jellyfish-api-core/src/category/wallet.ts 100.00% <0.00%> (ø)
packages/jellyfish-transaction/src/script/index.ts 100.00% <0.00%> (ø)
...ackages/jellyfish-api-core/src/category/account.ts 100.00% <0.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dfd345...f63f539. Read the comment docs.

@ivan-zynesis ivan-zynesis marked this pull request as ready for review June 3, 2021 01:37
@fuxingloh fuxingloh marked this pull request as draft June 4, 2021 10:49
@ivan-zynesis ivan-zynesis marked this pull request as ready for review June 8, 2021 04:33
@ivan-zynesis ivan-zynesis requested a review from fuxingloh June 8, 2021 09:04
@fuxingloh fuxingloh marked this pull request as draft June 8, 2021 16:45
@ivan-zynesis ivan-zynesis marked this pull request as ready for review June 9, 2021 01:56
@ivan-zynesis ivan-zynesis requested a review from fuxingloh June 10, 2021 01:13
Copy link
Contributor

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 more test for safety

@thedoublejay thedoublejay self-requested a review June 11, 2021 08:22
@fuxingloh fuxingloh merged commit 2b9bb1c into main Jun 11, 2021
@fuxingloh fuxingloh deleted the feature/mnemonic-wallet/passphrase-encrypt-seed branch June 11, 2021 09:19
eli-lim pushed a commit that referenced this pull request Mar 27, 2022
…rs behind (#331)

* reconfigure probes for idb

defid.readiness dead if defid blocks are more than 4 headers behind
model.readiness dead synced blocks are more than 4 blocks behind

* added probes healthy with peers testing

* Update _model.probes.ts
canonbrother pushed a commit that referenced this pull request Jun 1, 2022
…rs behind (#331)

* reconfigure probes for idb

defid.readiness dead if defid blocks are more than 4 headers behind
model.readiness dead synced blocks are more than 4 blocks behind

* added probes healthy with peers testing

* Update _model.probes.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New feature request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants