Skip to content

refactor jellyfish-wallet-encrypted encryption layer#477

Merged
fuxingloh merged 4 commits intomainfrom
fuxingloh/encrypted-wallet
Jul 22, 2021
Merged

refactor jellyfish-wallet-encrypted encryption layer#477
fuxingloh merged 4 commits intomainfrom
fuxingloh/encrypted-wallet

Conversation

@fuxingloh
Copy link
Contributor

What kind of PR is this?:

/kind refactor

What this PR does / why we need it:

Refactor jellyfish-wallet-encrypted encryption layer for a clearer inheritance for consumer implementation.

This removes storage & provider for re-implementation at wallet layer. To keep concerns separated as encryption layer should not handle storage.

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jul 21, 2021

Code Climate has analyzed commit dced4b9 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Jul 21, 2021

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/jellyfish/dist/index.umd.js 21.37 KB (0%) 428 ms (0%) 193 ms (-2.06% 🔽) 620 ms

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #477 (dced4b9) into main (9f1536d) will decrease coverage by 0.01%.
The diff coverage is 94.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #477      +/-   ##
==========================================
- Coverage   97.49%   97.48%   -0.02%     
==========================================
  Files         103      103              
  Lines        3038     3020      -18     
  Branches      380      380              
==========================================
- Hits         2962     2944      -18     
  Misses         76       76              
Impacted Files Coverage Δ
packages/jellyfish-wallet-encrypted/src/scrypt.ts 93.65% <93.65%> (ø)
packages/jellyfish-crypto/src/aes256.ts 100.00% <100.00%> (ø)
packages/jellyfish-wallet-encrypted/src/index.ts 100.00% <100.00%> (ø)
...ish-wallet-encrypted/src/provider/scrypt_simple.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f1536d...dced4b9. Read the comment docs.

@fuxingloh fuxingloh marked this pull request as ready for review July 21, 2021 16:48
@fuxingloh fuxingloh requested a review from ivan-zynesis as a code owner July 21, 2021 16:48
@fuxingloh fuxingloh merged commit eb6c7ae into main Jul 22, 2021
@fuxingloh fuxingloh deleted the fuxingloh/encrypted-wallet branch July 22, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/refactor Non feature refactor change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants